Commit 37cfd8c
authored
Remove Node.js self.run_js() test in browser suite. (#25473)
Remove Node.js self.run_js() test in browser suite. The browser suite
should test browser behavior only.
I am running the browser suite with
```
EMCC_CFLAGS= -sMIN_CHROME_VERSION=-1 -sMIN_SAFARI_VERSION=-1 -sMIN_NODE_VERSION=-1
```
to verify that targeting Firefox only should correctly result in a build
that works in Firefox.
The test `test_hello_world_worker` is the only one that failed. Which
happens because that test also verifies behavior in node.js.
Reading the test logic in that test, it seems to verify the file
packager and `emscripten_run_script()` logic. That logic should be well
covered in the `core` test suites and the `other` test suite already, so
this seems redundant.1 parent 8bd4bec commit 37cfd8c
2 files changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1095 | 1095 | | |
1096 | 1096 | | |
1097 | 1097 | | |
1098 | | - | |
1099 | 1098 | | |
1100 | 1099 | | |
1101 | 1100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1617 | 1617 | | |
1618 | 1618 | | |
1619 | 1619 | | |
1620 | | - | |
1621 | | - | |
1622 | | - | |
1623 | | - | |
1624 | | - | |
1625 | | - | |
1626 | 1620 | | |
1627 | 1621 | | |
1628 | 1622 | | |
| |||
0 commit comments