Skip to content

Commit 37cfd8c

Browse files
authored
Remove Node.js self.run_js() test in browser suite. (#25473)
Remove Node.js self.run_js() test in browser suite. The browser suite should test browser behavior only. I am running the browser suite with ``` EMCC_CFLAGS= -sMIN_CHROME_VERSION=-1 -sMIN_SAFARI_VERSION=-1 -sMIN_NODE_VERSION=-1 ``` to verify that targeting Firefox only should correctly result in a build that works in Firefox. The test `test_hello_world_worker` is the only one that failed. Which happens because that test also verifies behavior in node.js. Reading the test logic in that test, it seems to verify the file packager and `emscripten_run_script()` logic. That logic should be well covered in the `core` test suites and the `other` test suite already, so this seems redundant.
1 parent 8bd4bec commit 37cfd8c

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

.circleci/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,6 @@ jobs:
10951095
executor: focal
10961096
environment:
10971097
EMTEST_LACKS_WEBGPU: "1"
1098-
EMTEST_SKIP_NODE_CANARY: "1"
10991098
steps:
11001099
- run-tests-chrome:
11011100
title: "browser64_4gb"

test/test_browser.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1617,12 +1617,6 @@ def test_hello_world_worker(self, file_data):
16171617
self.assertExists('worker.js')
16181618
self.run_browser('main.html', '/report_result?hello from worker, and :' + ('data for w' if file_data else '') + ':')
16191619

1620-
# code should run standalone too
1621-
# To great memories >4gb we need the canary version of node
1622-
if self.is_4gb():
1623-
self.require_node_canary()
1624-
self.assertContained('you should not see this text when in a worker!', self.run_js('worker.js'))
1625-
16261620
@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/19608')
16271621
def test_mmap_lazyfile(self):
16281622
create_file('lazydata.dat', 'hello world')

0 commit comments

Comments
 (0)