Skip to content

Commit 38b34de

Browse files
authored
Warn that SUPPORT_BIG_ENDIAN is experimental (#25058)
Support for big endian targets is "best effort" and not fully supported or tested. Also, as far as I'm aware there is only one or two users of this feature so I think it makes sense for it to stay as "best effort" for the foreseeable future. See #25042
1 parent fa80ed0 commit 38b34de

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,8 @@ function call that uses DataView to enforce LE byte order for HEAP buffer;
427427
This makes generated JavaScript run on BE as well as LE machines. (If 0, only
428428
LE systems are supported). Does not affect generated wasm.
429429

430+
.. note:: This is an experimental setting
431+
430432
Default value: false
431433

432434
.. _safe_heap:

src/settings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ var INLINING_LIMIT = false;
317317
// function call that uses DataView to enforce LE byte order for HEAP buffer;
318318
// This makes generated JavaScript run on BE as well as LE machines. (If 0, only
319319
// LE systems are supported). Does not affect generated wasm.
320+
// [experimental]
320321
var SUPPORT_BIG_ENDIAN = false;
321322

322323
// Check each write to the heap, for example, this will give a clear

tools/link.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,9 @@ def phase_linker_setup(options, linker_args): # noqa: C901, PLR0912, PLR0915
840840
if settings.GROWABLE_ARRAYBUFFERS:
841841
diagnostics.warning('experimental', '-sGROWABLE_ARRAYBUFFERS is still experimental and not yet supported in browsers')
842842

843+
if settings.SUPPORT_BIG_ENDIAN:
844+
diagnostics.warning('experimental', '-sSUPPORT_BIG_ENDIAN is experimental, not all features are fully supported.')
845+
843846
if settings.WASM_ESM_INTEGRATION:
844847
diagnostics.warning('experimental', '-sWASM_ESM_INTEGRATION is still experimental and not yet supported in browsers')
845848
default_setting('MODULARIZE', 'instance')

0 commit comments

Comments
 (0)