Remove the need for runCaller. NFC (#23193)

This change removes the need for `runCaller` and the `calledRun` global.
Instead we simply set `dependenciesFulfilled` to `run` directly each
time to return early due to outstanding dependencies.

This also means that we don't need a reentrancy check on `doRun` since
`dependenciesFulfilled` is only set in the case where `doRun` didn't
actually run.

This both simplifies the code and saves on code size.

Author: sbc100

src/postamble.js

@@ -26,18 +26,14 @@ if (ENVIRONMENT_IS_WORKER) {
 
 {{{ exportRuntime() }}}
 
+#if ASSERTIONS
 var calledRun;
+#endif
 
 #if STANDALONE_WASM && MAIN_READS_PARAMS
 var mainArgs = undefined;
 #endif
 
-dependenciesFulfilled = function runCaller() {
-  // If run has never been called, and we should call run (INVOKE_RUN is true, and Module.noInitialRun is not false)
-  if (!calledRun) run();
-  if (!calledRun) dependenciesFulfilled = runCaller; // try this again later, after new deps are fulfilled
-};
-
 #if HAS_MAIN
 #if MAIN_READS_PARAMS
 {{{ asyncIf(ASYNCIFY == 2) }}} function callMain(args = []) {
@@ -152,6 +148,7 @@ function run() {
 #if RUNTIME_DEBUG
     dbg('run() called, but dependencies remain, so not running');
 #endif
+    dependenciesFulfilled = run;
     return;
   }
 
@@ -176,14 +173,17 @@ function run() {
 #if RUNTIME_DEBUG
     dbg('run() called, but dependencies remain, so not running');
 #endif
+    dependenciesFulfilled = run;
     return;
   }
 
   function doRun() {
     // run may have just been called through dependencies being fulfilled just in this very frame,
     // or while the async setStatus time below was happening
-    if (calledRun) return;
+#if ASSERTIONS
+    assert(!calledRun);
     calledRun = true;
+#endif
     Module['calledRun'] = true;
 
     if (ABORT) return;

test/other/codesize/test_codesize_cxx_ctors1.gzsize

@@ -1 +1 @@
-8529
+8505

test/other/codesize/test_codesize_cxx_ctors1.jssize

@@ -1 +1 @@
-20897
+20848

test/other/codesize/test_codesize_cxx_ctors2.gzsize

@@ -1 +1 @@
-8514
+8489

test/other/codesize/test_codesize_cxx_ctors2.jssize

@@ -1 +1 @@
-20865
+20816

test/other/codesize/test_codesize_cxx_except.gzsize

@@ -1 +1 @@
-9561
+9532

test/other/codesize/test_codesize_cxx_except.jssize

@@ -1 +1 @@
-24743
+24693

test/other/codesize/test_codesize_cxx_except_wasm.gzsize

@@ -1 +1 @@
-8488
+8462

test/other/codesize/test_codesize_cxx_except_wasm.jssize

@@ -1 +1 @@
-20791
+20742

test/other/codesize/test_codesize_cxx_except_wasm_exnref.gzsize

@@ -1 +1 @@
-8488
+8462