Bump min Firefox version to 68 ESR

Author: juj

ChangeLog.md

@@ -27,6 +27,7 @@ See docs/process.md for more on how version tagging works.
   - Node: v10.19.0 -> v12.22.9
   - Chrome: v70 -> v74
   - Firefox: v55 -> v65
+  - Minimum Firefox version was further bumped up to Firefox 68 ESR
 - The Embind `val` functions `call`, `operator()`, and `new_` now support
   passing `pointer`s by using the `allow_raw_pointers()` argument. This feature
   is only enabled with C++17 and newer. Older versions will allow pointers by

site/source/docs/tools_reference/settings_reference.rst

@@ -2871,7 +2871,7 @@ are desired to work. Pass -sMIN_FIREFOX_VERSION=majorVersion to drop support
 for Firefox versions older than < majorVersion.
 Firefox 79 was released on 2020-07-28.
 MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
-Minimum supported value is 65 which was released on 2019-01-29 (see
+Minimum supported value is 68 which was released on 2019-07-09 (see
 feature_matrix.py)
 
 Default value: 79

src/settings.js

@@ -1880,7 +1880,7 @@ var AUTO_NATIVE_LIBRARIES = true;
 // for Firefox versions older than < majorVersion.
 // Firefox 79 was released on 2020-07-28.
 // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
-// Minimum supported value is 65 which was released on 2019-01-29 (see
+// Minimum supported value is 68 which was released on 2019-07-09 (see
 // feature_matrix.py)
 // [link]
 var MIN_FIREFOX_VERSION = 79;

test/test_other.py

@@ -14391,8 +14391,8 @@ def test_min_browser_version(self):
     err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=130000'])
     self.assertContained('emcc: error: MIN_SAFARI_VERSION=130000 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)', err)
 
-    err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=65'])
-    self.assertContained('emcc: error: MIN_FIREFOX_VERSION=65 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
+    err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=68'])
+    self.assertContained('emcc: error: MIN_FIREFOX_VERSION=68 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
 
   # Test that using two different ways to disable a target environment at the same time will not produce a warning.
   def test_double_disable_environment(self):

tools/feature_matrix.py

@@ -23,7 +23,7 @@
 # N.b. when modifying these values, update comments in src/settings.js on
 # MIN_x_VERSION fields to match accordingly.
 OLDEST_SUPPORTED_CHROME = 74  # Released on 2019-04-23
-OLDEST_SUPPORTED_FIREFOX = 65  # Released on 2019-01-29
+OLDEST_SUPPORTED_FIREFOX = 68  # Released on 2019-07-09
 OLDEST_SUPPORTED_SAFARI = 120200  # Released on 2019-03-25
 # 12.22.09 is the oldest version of node that we do any testing with.
 # Keep this in sync with the test-node-compat in .circleci/config.yml.