Skip to content

Commit 4e45121

Browse files
authored
[file_packager] Remove AV_WORKAROUND (#24980)
This was added back in 2012 (ac36f1a) but I don't think its been used in years and its not documented or tested.
1 parent 8e4b3f9 commit 4e45121

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

tools/file_packager.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
import json
7575
import os
7676
import posixpath
77-
import random
7877
import shutil
7978
import sys
8079
from subprocess import PIPE
@@ -91,10 +90,6 @@
9190

9291
DEBUG = os.environ.get('EMCC_DEBUG')
9392

94-
# Set to 1 to randomize file order and add some padding,
95-
# to work around silly av false positives
96-
AV_WORKAROUND = 0
97-
9893
excluded_patterns: List[str] = []
9994
new_data_files = []
10095
walked = []
@@ -562,9 +557,6 @@ def was_seen(name):
562557
data_files = sorted(data_files, key=lambda file_: file_.dstpath)
563558
data_files = [file_ for file_ in data_files if not was_seen(file_.dstpath)]
564559

565-
if AV_WORKAROUND:
566-
random.shuffle(data_files)
567-
568560
# Apply plugins
569561
for file_ in data_files:
570562
for plugin in plugins:
@@ -688,8 +680,6 @@ def generate_js(data_target, data_files, metadata):
688680
file_.data_start = start
689681
curr = utils.read_binary(file_.srcpath)
690682
file_.data_end = start + len(curr)
691-
if AV_WORKAROUND:
692-
curr += '\x00'
693683
start += len(curr)
694684
data.write(curr)
695685

0 commit comments

Comments
 (0)