[wasm64] Remove temporary toIndexType workaround

Now the firefox and chrome both use BigInt for indexing 64-bit memories
and tables this workaround is no longer needed.

Author: sbc100

.circleci/config.yml

@@ -106,7 +106,7 @@ commands:
     description: "install canary version of node"
     steps:
       - install-node-version:
-         node_version: "23.0.0-v8-canary20240819f52f1c2f1c"
+         node_version: "24.0.0-v8-canary20241031a6869d77cc"
          canary: true
   install-v8:
     description: "install v8 using jsvu"

src/library.js

@@ -1907,6 +1907,7 @@ addToLibrary({
     // With ABORT_ON_WASM_EXCEPTIONS wasmTable.get is overridden to return wrapped
     // functions so we need to call it here to retrieve the potential wrapper correctly
     // instead of just storing 'func' directly into wasmTableMirror
+    /** @suppress {checkTypes} */
     wasmTableMirror[idx] = wasmTable.get({{{ toIndexType('idx') }}});
   },
 
@@ -1922,6 +1923,7 @@ addToLibrary({
     var func = wasmTableMirror[funcPtr];
     if (!func) {
       if (funcPtr >= wasmTableMirror.length) wasmTableMirror.length = funcPtr + 1;
+      /** @suppress {checkTypes} */
       wasmTableMirror[funcPtr] = func = wasmTable.get({{{ toIndexType('funcPtr') }}});
 #if ASYNCIFY == 2
       if (Asyncify.isAsyncExport(func)) {
@@ -1930,6 +1932,7 @@ addToLibrary({
 #endif
     }
 #if ASSERTIONS && ASYNCIFY != 2 // With JSPI the function stored in the table will be a wrapper.
+    /** @suppress {checkTypes} */
     assert(wasmTable.get({{{ toIndexType('funcPtr') }}}) == func, 'JavaScript-side Wasm function table mirror is out of date!');
 #endif
     return func;

src/parseTools.mjs

@@ -964,8 +964,7 @@ function from64Expr(x, assign = true) {
 }
 
 function toIndexType(x) {
-  if (MEMORY64 != 1) return x;
-  return `toIndexType(${x})`;
+  return to64(x);
 }
 
 function to64(x) {

src/runtime_shared.js

@@ -47,22 +47,6 @@ function updateMemoryViews() {
 #endif
 }
 
-#if MEMORY64 == 1
-var toIndexType = (function() {
-  // Probe for support of bigint bounds with memory64.
-  // TODO(sbc): Remove this once all browsers start requiring bigint here.
-  // See https://github.com/WebAssembly/memory64/issues/68
-  var bigintMemoryBounds = 1;
-  try {
-    /** @suppress {checkTypes} */
-    new WebAssembly.Memory({'initial': 1n, 'index': 'i64', 'address': 'i64'});
-  } catch (e) {
-    bigintMemoryBounds = 0;
-  }
-  return (i) => bigintMemoryBounds ? BigInt(i) : i;
-})();
-#endif
-
 #if ENVIRONMENT_MAY_BE_NODE && MIN_NODE_VERSION < 160000
 // The performance global was added to node in v16.0.0:
 // https://nodejs.org/api/globals.html#performance

test/other/codesize/test_codesize_minimal_64.gzsize

@@ -1 +1 @@
-1589
+1522

test/other/codesize/test_codesize_minimal_64.jssize

@@ -1 +1 @@
-3311
+3179