Skip to content

Commit 5ab4c12

Browse files
authored
Fix some WASMFS tests to pass (#25033)
1 parent 25d2139 commit 5ab4c12

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

test/test_core.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4763,6 +4763,10 @@ def test_dylink_postsets_chunking(self):
47634763
'missing_assertions': ('libc,libmalloc,libc++abi', False, False, True),
47644764
})
47654765
def test_dylink_syslibs(self, syslibs, expect_pass=True, with_reversed=True, assertions=True):
4766+
# When testing in WASMFS mode, we also need to force the WASMFS syslib into the test.
4767+
if self.get_setting('WASMFS') and syslibs != '1':
4768+
syslibs += ',libwasmfs'
4769+
47664770
# one module uses libcxx, need to force its inclusion when it isn't the main
47674771
if not with_reversed and self.dylink_reversed:
47684772
self.skipTest('with_reversed is false')
@@ -6187,6 +6191,9 @@ def test_unistd_write_broken_link(self):
61876191
@requires_node
61886192
@no_wasmfs('Assertion failed: "fd" in symlink_on_nodefs.c line 62. https://github.com/emscripten-core/emscripten/issues/25035')
61896193
def test_unistd_symlink_on_nodefs(self):
6194+
if self.get_setting('WASMFS'):
6195+
self.set_setting('FORCE_FILESYSTEM')
6196+
61906197
# Also, other detected discrepancies if you do end up running this test on NODEFS:
61916198
# test expects /, but Windows gives \ as path slashes.
61926199
# Calling readlink() on a non-link gives error 22 EINVAL on Unix, but simply error 0 OK on Windows.
@@ -6910,6 +6917,9 @@ def test_poppler(self):
69106917
@needs_make('make')
69116918
@is_slow_test
69126919
def test_openjpeg(self):
6920+
if self.get_setting('WASMFS'):
6921+
self.set_setting('FORCE_FILESYSTEM')
6922+
69136923
def line_splitter(data):
69146924
out = ''
69156925
counter = 0

0 commit comments

Comments
 (0)