Skip to content

Commit 5cfdfaa

Browse files
authored
Remove assertions on the return type of URL.createObjectURL. NFC (#24909)
`URL.createObjectURL` always returns a string. These assertions were added way back in 2012 (e1356dc) when perhaps the spec was new and not implemented correctly everywhere.
1 parent d7c8aa7 commit 5cfdfaa

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/lib/libbrowser.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ var LibraryBrowser = {
5454
b = new Blob([(new Uint8Array(byteArray)).buffer], { type: Browser.getMimetype(name) });
5555
}
5656
var url = URL.createObjectURL(b);
57-
#if ASSERTIONS
58-
assert(typeof url == 'string', 'createObjectURL must return a url as a string');
59-
#endif
6057
var img = new Image();
6158
img.onload = () => {
6259
#if ASSERTIONS
@@ -93,9 +90,6 @@ var LibraryBrowser = {
9390
}
9491
var b = new Blob([byteArray], { type: Browser.getMimetype(name) });
9592
var url = URL.createObjectURL(b); // XXX we never revoke this!
96-
#if ASSERTIONS
97-
assert(typeof url == 'string', 'createObjectURL must return a url as a string');
98-
#endif
9993
var audio = new Audio();
10094
audio.addEventListener('canplaythrough', () => finish(audio), false); // use addEventListener due to chromium bug 124926
10195
audio.onerror = function audio_onerror(event) {

0 commit comments

Comments
 (0)