Skip to content

Commit 6e9e558

Browse files
authored
Use arrow functions in handleSleep calls. NFC (#20200)
I noticed this while reviewing #20182.
1 parent 3fb907d commit 6e9e558

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

site/source/docs/porting/asyncify.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ code will resume:
185185
.. code-block:: cpp
186186
187187
EM_JS(int, do_fetch, (), {
188-
return Asyncify.handleSleep(function (wakeUp) {
188+
return Asyncify.handleSleep((wakeUp) => {
189189
out("waiting for a fetch");
190190
fetch("a.html").then(function (response) {
191191
out("got the fetch response");

src/library_async.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ addToLibrary({
191191
StackSize: {{{ ASYNCIFY_STACK_SIZE }}},
192192
currData: null,
193193
// The return value passed to wakeUp() in
194-
// Asyncify.handleSleep(function(wakeUp){...}) is stored here,
194+
// Asyncify.handleSleep((wakeUp) => {...}) is stored here,
195195
// so we can return it later from the C function that called
196196
// Asyncify.handleSleep() after rewinding finishes.
197197
handleSleepReturnValue: 0,

src/library_idbstore.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ var LibraryIDBStore = {
8181
emscripten_idb_load__async: true,
8282
emscripten_idb_load__deps: ['malloc'],
8383
emscripten_idb_load: (db, id, pbuffer, pnum, perror) => {
84-
return Asyncify.handleSleep(function(wakeUp) {
85-
IDBStore.getFile(UTF8ToString(db), UTF8ToString(id), function(error, byteArray) {
84+
return Asyncify.handleSleep((wakeUp) => {
85+
IDBStore.getFile(UTF8ToString(db), UTF8ToString(id), (error, byteArray) => {
8686
if (error) {
8787
{{{ makeSetValue('perror', 0, '1', 'i32') }}};
8888
wakeUp();
@@ -99,26 +99,26 @@ var LibraryIDBStore = {
9999
},
100100
emscripten_idb_store__async: true,
101101
emscripten_idb_store: (db, id, ptr, num, perror) => {
102-
return Asyncify.handleSleep(function(wakeUp) {
103-
IDBStore.setFile(UTF8ToString(db), UTF8ToString(id), new Uint8Array(HEAPU8.subarray(ptr, ptr+num)), function(error) {
102+
return Asyncify.handleSleep((wakeUp) => {
103+
IDBStore.setFile(UTF8ToString(db), UTF8ToString(id), new Uint8Array(HEAPU8.subarray(ptr, ptr+num)), (error) => {
104104
{{{ makeSetValue('perror', 0, '!!error', 'i32') }}};
105105
wakeUp();
106106
});
107107
});
108108
},
109109
emscripten_idb_delete__async: true,
110110
emscripten_idb_delete: (db, id, perror) => {
111-
return Asyncify.handleSleep(function(wakeUp) {
112-
IDBStore.deleteFile(UTF8ToString(db), UTF8ToString(id), function(error) {
111+
return Asyncify.handleSleep((wakeUp) => {
112+
IDBStore.deleteFile(UTF8ToString(db), UTF8ToString(id), (error) => {
113113
{{{ makeSetValue('perror', 0, '!!error', 'i32') }}};
114114
wakeUp();
115115
});
116116
});
117117
},
118118
emscripten_idb_exists__async: true,
119119
emscripten_idb_exists: (db, id, pexists, perror) => {
120-
return Asyncify.handleSleep(function(wakeUp) {
121-
IDBStore.existsFile(UTF8ToString(db), UTF8ToString(id), function(error, exists) {
120+
return Asyncify.handleSleep((wakeUp) => {
121+
IDBStore.existsFile(UTF8ToString(db), UTF8ToString(id), (error, exists) => {
122122
{{{ makeSetValue('pexists', 0, '!!exists', 'i32') }}};
123123
{{{ makeSetValue('perror', 0, '!!error', 'i32') }}};
124124
wakeUp();
@@ -128,9 +128,9 @@ var LibraryIDBStore = {
128128
// extra worker methods - proxied
129129
emscripten_idb_load_blob__async: true,
130130
emscripten_idb_load_blob: (db, id, pblob, perror) => {
131-
return Asyncify.handleSleep(function(wakeUp) {
131+
return Asyncify.handleSleep((wakeUp) => {
132132
assert(!IDBStore.pending);
133-
IDBStore.pending = function(msg) {
133+
IDBStore.pending = (msg) => {
134134
IDBStore.pending = null;
135135
var blob = msg.blob;
136136
if (!blob) {
@@ -154,9 +154,9 @@ var LibraryIDBStore = {
154154
},
155155
emscripten_idb_store_blob__async: true,
156156
emscripten_idb_store_blob: (db, id, ptr, num, perror) => {
157-
return Asyncify.handleSleep(function(wakeUp) {
157+
return Asyncify.handleSleep((wakeUp) => {
158158
assert(!IDBStore.pending);
159-
IDBStore.pending = function(msg) {
159+
IDBStore.pending = (msg) => {
160160
IDBStore.pending = null;
161161
{{{ makeSetValue('perror', 0, '!!msg.error', 'i32') }}};
162162
wakeUp();

test/browser/async_returnvalue.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111
// A "sync" tunnel that adds 1.
1212
#if USE_EM_JS
1313
EM_JS(int, sync_tunnel, (int value), {
14-
return Asyncify.handleSleep(function(wakeUp) {
14+
return Asyncify.handleSleep((wakeUp) => {
1515
setTimeout(function() {
1616
wakeUp(value + 1);
1717
}, 1);
1818
});
1919
})
2020
EM_JS(int, sync_tunnel_bool, (bool value), {
21-
return Asyncify.handleSleep(function(wakeUp) {
21+
return Asyncify.handleSleep((wakeUp) => {
2222
setTimeout(function() {
2323
wakeUp(!value);
2424
}, 1);

test/browser/async_returnvalue.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
addToLibrary({
22
sync_tunnel: function(value) {
3-
return Asyncify.handleSleep(function(wakeUp) {
3+
return Asyncify.handleSleep((wakeUp) => {
44
setTimeout(function() {
55
wakeUp(value + 1);
66
}, 1);
77
});
88
},
99
sync_tunnel_bool: function(value) {
10-
return Asyncify.handleSleep(function(wakeUp) {
10+
return Asyncify.handleSleep((wakeUp) => {
1111
setTimeout(function() {
1212
wakeUp(!value);
1313
}, 1);

test/core/test_asyncify_assertions.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include <emscripten.h>
33

44
EM_JS(void, suspend, (), {
5-
return Asyncify.handleSleep(function(wakeUp) {
5+
Asyncify.handleSleep((wakeUp) => {
66
Module.resume = wakeUp;
77
setTimeout(function() {
88
Module._resume_from_inside_c();

0 commit comments

Comments
 (0)