Commit 71e0500
authored
In !DECLARE_ASM_MODULE_EXPORTS that wasm symbols are all
programmatically exported onto the Module object, and after #25298 that
includes the `wasmMemory` symbol.
This happens even for symbols that were not included in
EXPORTED_FUNCTIONS or EXPORTED_RUNTIME_SYMBOLS. In many of these tests
`wasmMemory` was not being exported and so that
`unexportedRuntimeSymbol` helper was installing a property accessor on
the `Module` object, which did not all of the assignment within
`exportWasmSymbols`.
An alternative here would be to limit the list of symbols that
`exportWasmSymbols` assigns to the `Module` object but that would only
increase code size for very little benefit.
1 parent c9acde2 commit 71e0500
File tree
4 files changed
+16
-8
lines changed- .circleci
- src
- test/codesize
4 files changed
+16
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
694 | 694 | | |
695 | 695 | | |
696 | 696 | | |
| 697 | + | |
| 698 | + | |
697 | 699 | | |
698 | 700 | | |
699 | 701 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
158 | 164 | | |
159 | 165 | | |
160 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
416 | | - | |
| 416 | + | |
417 | 417 | | |
418 | 418 | | |
419 | 419 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| 2 | + | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
| 10 | + | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
0 commit comments