Skip to content

Commit 733f69e

Browse files
committed
Remove browser.test_small_js_flags
It's pretty much the same as test_small_js_flags, with difference in target environment only, and we should mostly care about size for the web anyway. We don't need to actually run this test, only compile.
1 parent abdb8a6 commit 733f69e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

test/test_browser.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4284,13 +4284,6 @@ def test_TextDecoder(self, args):
42844284
# the fallback is also expected to be larger in code size than using td
42854285
self.assertGreater(just_fallback, td_without_fallback)
42864286

4287-
def test_small_js_flags(self):
4288-
self.btest('browser_test_hello_world.c', '0', cflags=['-O3', '--closure=1', '-sINCOMING_MODULE_JS_API=[]', '-sENVIRONMENT=web', '--output-eol=linux'])
4289-
# Check an absolute js code size.
4290-
# Note that this size includes test harness additions (for reporting the result, etc.).
4291-
if not self.is_wasm64() and not self.is_2gb():
4292-
self.checkOutputSizes(['test.js'])
4293-
42944287
# Tests that it is possible to initialize and render WebGL content in a
42954288
# pthread by using OffscreenCanvas.
42964289
@no_chrome('https://crbug.com/961765')

test/test_other.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12323,7 +12323,7 @@ def test_main_reads_params(self):
1232312323

1232412324
def test_INCOMING_MODULE_JS_API(self):
1232512325
def test(args):
12326-
self.run_process([EMCC, test_file('hello_world.c'), '-O3', '--closure=1', '-sENVIRONMENT=node,shell', '--output-eol=linux'] + args)
12326+
self.run_process([EMCC, test_file('hello_world.c'), '-O3', '--closure=1', '-sENVIRONMENT=web', '--output-eol=linux'] + args)
1232712327
for engine in config.JS_ENGINES:
1232812328
self.assertContained('hello, world!', self.run_js('a.out.js', engine=engine))
1232912329
return os.path.getsize('a.out.js')
@@ -16218,3 +16218,10 @@ def test_install(self):
1621816218
# Some files, such as as maintenance tools should not be part of the
1621916219
# install.
1622016220
self.assertNotExists('newdir/tools/maint/')
16221+
16222+
def test_small_js_flags(self):
16223+
self.btest('browser_test_hello_world.c', '0', cflags=['-O3', '--closure=1', '-sINCOMING_MODULE_JS_API=[]', '-sENVIRONMENT=web', '--output-eol=linux'])
16224+
# Check an absolute js code size.
16225+
# Note that this size includes test harness additions (for reporting the result, etc.).
16226+
if not self.is_wasm64() and not self.is_2gb():
16227+
self.checkOutputSizes(['test.js'])

0 commit comments

Comments
 (0)