Skip to content

Commit 7378d2f

Browse files
authored
Bump min Firefox version to 68 ESR (#25493)
Firefox 66 and older are unable to run the parallel test harness.
1 parent 7f69e69 commit 7378d2f

File tree

7 files changed

+9
-20
lines changed

7 files changed

+9
-20
lines changed

ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ See docs/process.md for more on how version tagging works.
2020

2121
4.0.17 (in development)
2222
-----------------------
23+
- Minimum Firefox version was bumped up to Firefox 68 ESR, since older Firefox
24+
versions are not able to run the parallel browser harness: (#25493)
25+
- Firefox: v65 -> v68
2326

2427
4.0.16 - 10/07/25
2528
-----------------

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2871,7 +2871,7 @@ are desired to work. Pass -sMIN_FIREFOX_VERSION=majorVersion to drop support
28712871
for Firefox versions older than < majorVersion.
28722872
Firefox 79 was released on 2020-07-28.
28732873
MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
2874-
Minimum supported value is 65 which was released on 2019-01-29 (see
2874+
Minimum supported value is 68 which was released on 2019-07-09 (see
28752875
feature_matrix.py)
28762876

28772877
Default value: 79

src/lib/libwebgl.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -859,17 +859,6 @@ for (/**@suppress{duplicate}*/var i = 0; i <= {{{ GL_POOL_TEMP_BUFFERS_SIZE }}};
859859
if (gl.getContextAttributes().antialias) {
860860
context.defaultFboForbidBlitFramebuffer = true;
861861
}
862-
#if MIN_FIREFOX_VERSION < 67
863-
else {
864-
// The WebGL 2 blit path doesn't work in Firefox < 67 (except in fullscreen).
865-
// https://bugzil.la/1523030
866-
var firefoxMatch = navigator.userAgent.toLowerCase().match(/firefox\/(\d\d)/);
867-
if (firefoxMatch != null) {
868-
var firefoxVersion = firefoxMatch[1];
869-
context.defaultFboForbidBlitFramebuffer = firefoxVersion < 67;
870-
}
871-
}
872-
#endif
873862
#endif
874863

875864
// Create render targets to the FBO

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1880,7 +1880,7 @@ var AUTO_NATIVE_LIBRARIES = true;
18801880
// for Firefox versions older than < majorVersion.
18811881
// Firefox 79 was released on 2020-07-28.
18821882
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
1883-
// Minimum supported value is 65 which was released on 2019-01-29 (see
1883+
// Minimum supported value is 68 which was released on 2019-07-09 (see
18841884
// feature_matrix.py)
18851885
// [link]
18861886
var MIN_FIREFOX_VERSION = 79;

test/common.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,6 @@ def configure(data_dir):
116116
"""Chrome has no special configuration step."""
117117

118118

119-
# N.b. The earliest Firefox version that can run multithreaded browser harness
120-
# is Firefox 67. If you need to test earlier Firefox versions, use EMTEST_CORES=1
121-
# environment variable to revert to the single-threaded browser harness.
122119
class FirefoxConfig:
123120
data_dir_flag = '-profile '
124121
default_flags = ('-new-instance',)

test/test_other.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10530,7 +10530,7 @@ def compile(flags):
1053010530
compile(['-sMIN_SAFARI_VERSION=160000', '-mno-sign-ext'])
1053110531
verify_features_sec_linked('sign-ext', False)
1053210532
# Flag enabling overrides explicit browser version
10533-
compile(['-sMIN_FIREFOX_VERSION=65', '-msign-ext'])
10533+
compile(['-sMIN_FIREFOX_VERSION=68', '-msign-ext'])
1053410534
verify_features_sec_linked('sign-ext', True)
1053510535
# Flag disabling overrides explicit version for bulk memory
1053610536
compile(['-sMIN_SAFARI_VERSION=150000', '-mno-bulk-memory'])
@@ -14382,8 +14382,8 @@ def test_min_browser_version(self):
1438214382
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=130000'])
1438314383
self.assertContained('emcc: error: MIN_SAFARI_VERSION=130000 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)', err)
1438414384

14385-
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=65'])
14386-
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=65 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
14385+
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=68'])
14386+
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=68 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
1438714387

1438814388
# Test that using two different ways to disable a target environment at the same time will not produce a warning.
1438914389
def test_double_disable_environment(self):

tools/feature_matrix.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
# N.b. when modifying these values, update comments in src/settings.js on
2424
# MIN_x_VERSION fields to match accordingly.
2525
OLDEST_SUPPORTED_CHROME = 74 # Released on 2019-04-23
26-
OLDEST_SUPPORTED_FIREFOX = 65 # Released on 2019-01-29
26+
OLDEST_SUPPORTED_FIREFOX = 68 # Released on 2019-07-09
2727
OLDEST_SUPPORTED_SAFARI = 120200 # Released on 2019-03-25
2828
# 12.22.09 is the oldest version of node that we do any testing with.
2929
# Keep this in sync with the test-node-compat in .circleci/config.yml.

0 commit comments

Comments
 (0)