Reverse order of execution of runtime callbacks (#24012)

This makes the `addOn<X>` functions use `[].push()` instead of
`[].unshift()` for enqueueing callbacks properly (hooks were processed
in the correct order, but runtime callbacks in each hook were enqueued
and executed in reverse compared to the order of registration).

The `AT<X>.unshift('callRuntimeCallbacks(on<X>);')` lines ensure runtime
callbacks are always executed before compile time callbacks.

Related tests updated accordingly.

Author: lvlte

src/lib/libcore.js

@@ -2300,7 +2300,7 @@ addToLibrary({
     ATPRERUNS.unshift('callRuntimeCallbacks(onPreRuns);');
   },
   $addOnPreRun__deps: ['$onPreRuns'],
-  $addOnPreRun: (cb) => onPreRuns.unshift(cb),
+  $addOnPreRun: (cb) => onPreRuns.push(cb),
   // See ATINITS in parseTools.mjs for more information.
   $onInits: [],
   $onInits__internal: true,
@@ -2309,7 +2309,7 @@ addToLibrary({
     ATINITS.unshift('callRuntimeCallbacks(onInits);');
   },
   $addOnInit__deps: ['$onInits'],
-  $addOnInit: (cb) => onInits.unshift(cb),
+  $addOnInit: (cb) => onInits.push(cb),
   // See ATPOSTCTORS in parseTools.mjs for more information.
   $onPostCtors: [],
   $onPostCtors__internal: true,
@@ -2318,7 +2318,7 @@ addToLibrary({
     ATPOSTCTORS.unshift('callRuntimeCallbacks(onPostCtors);');
   },
   $addOnPostCtor__deps: ['$onPostCtors'],
-  $addOnPostCtor: (cb) => onPostCtors.unshift(cb),
+  $addOnPostCtor: (cb) => onPostCtors.push(cb),
   // See ATMAINS in parseTools.mjs for more information.
   $onMains: [],
   $onMains__internal: true,
@@ -2327,7 +2327,7 @@ addToLibrary({
     ATMAINS.unshift('callRuntimeCallbacks(onMains);');
   },
   $addOnPreMain__deps: ['$onMains'],
-  $addOnPreMain: (cb) => onMains.unshift(cb),
+  $addOnPreMain: (cb) => onMains.push(cb),
   // See ATEXITS in parseTools.mjs for more information.
   $onExits: [],
   $onExits__internal: true,
@@ -2336,7 +2336,7 @@ addToLibrary({
     ATEXITS.unshift('callRuntimeCallbacks(onExits);');
   },
   $addOnExit__deps: ['$onExits'],
-  $addOnExit: (cb) => onExits.unshift(cb),
+  $addOnExit: (cb) => onExits.push(cb),
   // See ATPOSTRUNS in parseTools.mjs for more information.
   $onPostRuns: [],
   $onPostRuns__internal: true,
@@ -2345,7 +2345,7 @@ addToLibrary({
     ATPOSTRUNS.unshift('callRuntimeCallbacks(onPostRuns);');
   },
   $addOnPostRun__deps: ['$onPostRuns'],
-  $addOnPostRun: (cb) => onPostRuns.unshift(cb),
+  $addOnPostRun: (cb) => onPostRuns.push(cb),
 
   // We used to define these globals unconditionally in support code.
   // Instead, we now define them here so folks can pull it in explicitly, on

src/postamble.js

@@ -291,7 +291,7 @@ function checkUnflushedContent() {
 if (Module['preInit']) {
   if (typeof Module['preInit'] == 'function') Module['preInit'] = [Module['preInit']];
   while (Module['preInit'].length > 0) {
-    Module['preInit'].pop()();
+    Module['preInit'].shift()();
   }
 }
 #if ASSERTIONS

test/other/codesize/test_codesize_cxx_ctors1.gzsize

@@ -1 +1 @@
-8232
+8233

test/other/codesize/test_codesize_cxx_ctors1.jssize

@@ -1 +1 @@
-19993
+19989

test/other/codesize/test_codesize_cxx_ctors2.gzsize

@@ -1 +1 @@
-8221
+8220

test/other/codesize/test_codesize_cxx_ctors2.jssize

@@ -1 +1 @@
-19971
+19967

test/other/codesize/test_codesize_cxx_except.jssize

@@ -1 +1 @@
-23730
+23726

test/other/codesize/test_codesize_cxx_except_wasm.gzsize

@@ -1 +1 @@
-8177
+8176

test/other/codesize/test_codesize_cxx_except_wasm.jssize

@@ -1 +1 @@
-19885
+19881

test/other/codesize/test_codesize_cxx_except_wasm_legacy.gzsize

@@ -1 +1 @@
-8177
+8176