Skip to content

Commit 7dd821f

Browse files
committed
Fix getaddrinfo for IPv6 loopback address
1 parent 2b0980d commit 7dd821f

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/library.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,7 @@ addToLibrary({
10731073
if (family === {{{ cDefs.AF_INET }}}) {
10741074
addr = _htonl({{{ cDefs.INADDR_LOOPBACK }}});
10751075
} else {
1076-
addr = [0, 0, 0, 1];
1076+
addr = [0, 0, 0, _htonl(1)];
10771077
}
10781078
}
10791079
ai = allocaddrinfo(family, type, proto, null, addr, port);

test/sockets/test_getaddrinfo.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,7 @@ int main() {
122122
print_addrinfo(servinfo);
123123
assert(servinfo->ai_family == AF_INET6);
124124
assert(servinfo->ai_socktype == SOCK_STREAM);
125-
#ifndef __EMSCRIPTEN__
126-
// TODO(sbc): This assert currently fails under emscripten, but should not
127125
assert(memcmp(&sa6->sin6_addr, &in6addr_loopback, sizeof(in6addr_loopback)) == 0);
128-
#endif
129126
assert(sa6->sin6_port == ntohs(81));
130127
freeaddrinfo(servinfo);
131128

0 commit comments

Comments
 (0)