Split up test/unistd/access.c. NFC (#23752)

Author: sbc100

test/unistd/access.c

@@ -14,27 +14,17 @@
 #include <sys/stat.h>
 #include <unistd.h>
 
-int main() {
+void setup() {
   EM_ASM(
     FS.writeFile('forbidden', ""); FS.chmod('forbidden', 0o000);
     FS.writeFile('readable',  ""); FS.chmod('readable',  0o444);
     FS.writeFile('writeable', ""); FS.chmod('writeable', 0o222);
     FS.writeFile('allaccess', ""); FS.chmod('allaccess', 0o777);
-    FS.writeFile('fchmodtest', "");
   );
+}
 
-  // Empty path checks #9136 fix
-  char* files[] = {"readable", "writeable",
-                   "allaccess", "forbidden", "nonexistent", ""};
-  for (int i = 0; i < sizeof files / sizeof files[0]; i++) {
-    printf("F_OK('%s'): %s\n", files[i], access(files[i], F_OK) < 0 ? strerror(errno) : "OK");
-    printf("R_OK('%s'): %s\n", files[i], access(files[i], R_OK) < 0 ? strerror(errno) : "OK");
-    printf("X_OK('%s'): %s\n", files[i], access(files[i], X_OK) < 0 ? strerror(errno) : "OK");
-    printf("W_OK('%s'): %s\n", files[i], access(files[i], W_OK) < 0 ? strerror(errno) : "OK");
-    printf("\n");
-  }
-
-  EM_ASM({FS.writeFile('filetorename',  'renametest');});
+void test_rename() {
+  EM_ASM({FS.writeFile('filetorename', 'renametest');});
 
   int rename_ret = rename("filetorename", "renamedfile");
   assert(rename_ret == 0);
@@ -45,7 +35,10 @@ int main() {
   // Same againt with faccessat
   printf("F_OK('%s'): %d\n", "filetorename", faccessat(AT_FDCWD, "filetorename", F_OK, 0));
   printf("F_OK('%s'): %d\n", "renamedfile", faccessat(AT_FDCWD, "renamedfile", F_OK, 0));
+}
 
+void test_fchmod() {
+  EM_ASM({FS.writeFile('fchmodtest', "");});
   chmod("fchmodtest", S_IRUGO | S_IWUGO);
   struct stat fileStats;
   stat("fchmodtest", &fileStats);
@@ -60,7 +53,9 @@ int main() {
   );
   stat("fchmodtest", &fileStats);
   assert((fileStats.st_mode & 0777) == 0777);
+}
 
+void test_lchmod() {
 #if !defined(NODEFS) && !defined(NODERAWFS)
   // Node (and indeed linux) does not support lchmod
   // so skip this part of the test.
@@ -74,11 +69,14 @@ int main() {
   lstat("symlinkfile", &symlinkStats);
   assert((symlinkStats.st_mode & 0777) == 0777);
 
+  struct stat fileStats;
   stat("writeable", &fileStats);
-  mode = fileStats.st_mode & 0777;
+  int mode = fileStats.st_mode & 0777;
   assert(mode == S_IWUGO || mode == (S_IWUGO | S_IXUGO));
 #endif
+}
 
+void test_chmod_errors() {
   EM_ASM(
     var ex;
     try {
@@ -102,18 +100,26 @@ int main() {
     }
     assert(ex.name === "ErrnoError" && ex.errno === 44 /* ENOENT */);
   );
+}
 
+int main() {
+  setup();
 
-  // Restore full permissions on all created files so that python test runner rmtree
-  // won't have problems on deleting the files. On Windows, calling shutil.rmtree()
-  // will fail if any of the files are read-only.
-  EM_ASM(
-    FS.chmod('forbidden', 0777);
-    FS.chmod('readable',  0777);
-    FS.chmod('writeable', 0777);
-    FS.chmod('allaccess', 0777);
-    FS.chmod('fchmodtest', 0777);
-  );
+  // Empty path checks #9136 fix
+  char* files[] = {"readable", "writeable",
+                   "allaccess", "forbidden", "nonexistent", ""};
+  for (int i = 0; i < sizeof files / sizeof files[0]; i++) {
+    printf("F_OK('%s'): %s\n", files[i], access(files[i], F_OK) < 0 ? strerror(errno) : "OK");
+    printf("R_OK('%s'): %s\n", files[i], access(files[i], R_OK) < 0 ? strerror(errno) : "OK");
+    printf("X_OK('%s'): %s\n", files[i], access(files[i], X_OK) < 0 ? strerror(errno) : "OK");
+    printf("W_OK('%s'): %s\n", files[i], access(files[i], W_OK) < 0 ? strerror(errno) : "OK");
+    printf("\n");
+  }
+
+  test_rename();
+  test_fchmod();
+  test_lchmod();
+  test_chmod_errors();
 
   return 0;
 }