Skip to content

Commit 925c6c6

Browse files
authored
Move the removal of flaky tests from previous run to also take place in singlethreaded runs. (#25269)
1 parent bf22fd2 commit 925c6c6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/parallel_testsuite.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,6 @@ def run(self, result):
111111
# issues.
112112
# multiprocessing.set_start_method('spawn')
113113

114-
# Remove any old stale list of flaky tests before starting the run
115-
utils.delete_file(common.flaky_tests_log_filename)
116-
117114
tests = self.get_sorted_tests()
118115
contains_browser_test = any(test.is_browser_test() for test in tests)
119116
use_cores = cap_max_workers_in_pool(min(self.max_cores, len(tests), num_cores()), contains_browser_test)

test/runner.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -562,6 +562,9 @@ def set_env(name, option_value):
562562

563563
check_js_engines()
564564

565+
# Remove any old test files before starting the run
566+
utils.delete_file(common.flaky_tests_log_filename)
567+
565568
def prepend_default(arg):
566569
if arg.startswith('test_'):
567570
return default_core_test_mode + '.' + arg

0 commit comments

Comments
 (0)