Skip to content

Commit 93677b2

Browse files
authored
Move -D_LIBCPP_ABI_VERSION=2 into source code. NFC (#16427)
There is no reason that I can see to set this in emcc.py.
1 parent edf2711 commit 93677b2

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

emcc.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -878,10 +878,6 @@ def get_cflags(user_args):
878878
for a in building.llvm_backend_args():
879879
cflags += ['-mllvm', a]
880880

881-
# Set the LIBCPP ABI version to at least 2 so that we get nicely aligned string
882-
# data and other nice fixes.
883-
cflags += ['-D_LIBCPP_ABI_VERSION=2']
884-
885881
# Changes to default clang behavior
886882

887883
# Implicit functions can cause horribly confusing function pointer type errors, see #2175
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
// empty
1+
// Set the LIBCPP ABI version 2 under emscripten so that we get nicely aligned string
2+
// data and other nice fixes.
3+
#define _LIBCPP_ABI_VERSION 2

0 commit comments

Comments
 (0)