Enable WASM_BIGINT by default (#22993)

Enables by default by temporarily reducing required Safari version.

Also includes bugfixes for WASM_BIGINT compatibility.

Author: dschuff

ChangeLog.md

@@ -1498,7 +1498,7 @@ var DYNCALLS = false;
 // i64 is used. If WASM_BIGINT is present, the default minimum supported browser
 // versions will be increased to the min version that supports BigInt.
 // [link]
-var WASM_BIGINT = false;
+var WASM_BIGINT = true;
 
 // WebAssembly defines a "producers section" which compilers and tools can
 // annotate themselves in, and LLVM emits this by default.

site/source/docs/tools_reference/settings_reference.rst

@@ -34,7 +34,8 @@ var Module = typeof {{{ EXPORT_NAME }}} != 'undefined' ? {{{ EXPORT_NAME }}} : {
 #endif // USE_CLOSURE_COMPILER
 
 #if POLYFILL
-#if WASM_BIGINT && MIN_SAFARI_VERSION < 150000
+#if WASM_BIGINT && MIN_SAFARI_VERSION < 140100
+// TODO(https://github.com/emscripten-core/emscripten/issues/23184): Fix this back to 150000
 // See https://caniuse.com/mdn-javascript_builtins_bigint64array
 #include "polyfill/bigint64array.js"
 #endif

src/settings.js

@@ -1 +1 @@
-4297
+4380

src/shell.js

@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 380,
-  "a.js": 9593,
-  "a.js.gz": 4230,
-  "a.wasm": 7615,
-  "a.wasm.gz": 3471,
-  "total": 17760,
-  "total_gz": 8081
+  "a.js": 9879,
+  "a.js.gz": 4288,
+  "a.wasm": 7580,
+  "a.wasm.gz": 3449,
+  "total": 18011,
+  "total_gz": 8117
 }

test/browser/test_small_js_flags.js.size

@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 380,
-  "a.js": 6724,
-  "a.js.gz": 2900,
-  "a.wasm": 9528,
-  "a.wasm.gz": 4896,
-  "total": 16804,
-  "total_gz": 8176
+  "a.js": 7153,
+  "a.js.gz": 3042,
+  "a.wasm": 9493,
+  "a.wasm.gz": 4872,
+  "total": 17198,
+  "total_gz": 8294
 }

test/code_size/embind_hello_wasm.json

@@ -37,7 +37,7 @@
 from tools.shared import get_canonical_temp_dir, path_from_root
 from tools.utils import MACOS, WINDOWS, read_file, read_binary, write_binary, exit_with_error
 from tools.settings import COMPILE_TIME_SETTINGS
-from tools import shared, line_endings, building, config, utils
+from tools import shared, feature_matrix, line_endings, building, config, utils
 
 logger = logging.getLogger('common')
 
@@ -1164,6 +1164,8 @@ def setUp(self):
       if node_version < emcc_min_node_version:
         self.emcc_args += building.get_emcc_node_flags(node_version)
         self.emcc_args.append('-Wno-transpile')
+      if node_version[0] < feature_matrix.min_browser_versions[feature_matrix.Feature.JS_BIGINT_INTEGRATION]['node'] / 10000:
+        self.emcc_args.append('-sWASM_BIGINT=0')
 
     self.v8_args = ['--wasm-staging']
     self.env = {}

test/code_size/embind_val_wasm.json

@@ -2,11 +2,6 @@ __indirect_function_table
 __wasm_call_ctors
 _emscripten_stack_alloc
 _emscripten_stack_restore
-dynCall_iiiiiijj
-dynCall_iiiiij
-dynCall_iiiiijj
-dynCall_jiji
-dynCall_viijii
 emscripten_stack_get_current
 main
 memory

test/common.py

@@ -1 +1 @@
-8502
+8352