You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Skip whole browser test, not just the execution part (#25426)
I am running browser test suites several times, with
```
set EMCC_CFLAGS=-sMIN_FIREFOX_VERSION=xyz -Wno-unused-command-line-argument
```
but even when I also set the environment variables
```
set EMTEST_LACKS_OFFSCREEN_CANVAS=1
set EMTEST_LACKS_ES6_WORKERS=1
```
to skip the relevant ES6 or OffscreenCanvas tests that the Firefox
browser under test does not support, the test will actually not skip,
but still produce a test failure.
This is because the `skipExecIf()` function used to build the
`@requires_offscreen_canvas` and `@requires_es6_workers` decorators will
still attempt to compile the test, and only skip running it in the
browser.
But when I have set e.g. `EMCC_CFLAGS=-sMIN_FIREFOX_VERSION=95`, then
that Firefox does not support OffscreenCanvas, and it does not help even
if I also set the env. var. `EMTEST_LACKS_OFFSCREEN_CANVAS=1`. The
failing compilation still happens, and the test fails.
This PR fixes that issue by making EMTEST_LACKS_OFFSCREEN_CANVAS and
EMTEST_LACKS_ES6_WORKERS skip the whole test, and not just the browser
execution part.
Though this does have the drawback that CircleCI coverage might be
reduced, e.g. for the OffscreenCanvas tests parts, if it was seen
valuable to still compile those on targets that don't support
OffscreenCanvas. But is that important anymore?
0 commit comments