Skip to content

Commit 992775c

Browse files
authored
[CI] Remove --experimental-wasm-stack-switching from chrome flags. (#25391)
It looks like this flag was removed, causing the flags after it to be ignored: ``` Error: unrecognized flag --experimental-wasm-stack-switching The remaining arguments were ignored: --experimental-wasm-type-reflection --experimental-wasm-rab-integration ```
1 parent 3aab394 commit 992775c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.circleci/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ commands:
4242
# If that download link breaks, temporarily use this URL instead:
4343
# wget -O ~/chrome.deb https://storage.googleapis.com/webassembly/chrome/google-chrome-stable_current_amd64.deb
4444
dpkg -i ~/chrome.deb
45+
echo "Chrome version:"
46+
/usr/bin/google-chrome --version
4547
emsdk-env:
4648
description: "emsdk_env.sh"
4749
steps:

test/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class ChromeConfig:
9898
# --no-sandbox because we are running as root and chrome requires
9999
# this flag for now: https://crbug.com/638180
100100
'--no-first-run -start-maximized --no-sandbox --enable-unsafe-swiftshader --use-gl=swiftshader --enable-experimental-web-platform-features --enable-features=JavaScriptSourcePhaseImports',
101-
'--enable-experimental-webassembly-features --js-flags="--experimental-wasm-stack-switching --experimental-wasm-type-reflection --experimental-wasm-rab-integration"',
101+
'--enable-experimental-webassembly-features --js-flags="--experimental-wasm-type-reflection --experimental-wasm-rab-integration"',
102102
# The runners lack sound hardware so fallback to a dummy device (and
103103
# bypass the user gesture so audio tests work without interaction)
104104
'--use-fake-device-for-media-stream --autoplay-policy=no-user-gesture-required',

0 commit comments

Comments
 (0)