Feedback from #25249 (#25264)

sbc100 · web-flow · commit a264a9e3a36f · 2025-09-11T13:07:15.000-07:00
See #25249
diff --git a/src/lib/libdylink.js b/src/lib/libdylink.js
@@ -1314,7 +1314,7 @@ var LibraryDylink = {
     assert(lib, `Tried to dlsym() from an unopened handle: ${handle}`);
 #endif
     newSymIndex = Object.keys(lib.exports).indexOf(symbol);
-    if (newSymIndex == -1 || lib.exports[symbol]?.stub) {
+    if (newSymIndex == -1 || lib.exports[symbol].stub) {
       dlSetError(`Tried to lookup unknown symbol "${symbol}" in dynamic lib: ${lib.name}`)
       return 0;
     }
diff --git a/test/code_size/test_codesize_hello_dylink_all.json b/test/code_size/test_codesize_hello_dylink_all.json
@@ -1,7 +1,7 @@
 {
-  "a.out.js": 246022,
+  "a.out.js": 246021,
   "a.out.nodebug.wasm": 597767,
-  "total": 843789,
+  "total": 843788,
   "sent": [
     "IMG_Init",
     "IMG_Load",

Original file line number	Diff line number	Diff line change
`@@ -1314,7 +1314,7 @@ var LibraryDylink = {`
`1314`	`1314`	assert(lib, `Tried to dlsym() from an unopened handle: ${handle}`);
`1315`	`1315`	`#endif`
`1316`	`1316`	`newSymIndex = Object.keys(lib.exports).indexOf(symbol);`
`1317`		`- if (newSymIndex == -1 \|\| lib.exports[symbol]?.stub) {`
	`1317`	`+ if (newSymIndex == -1 \|\| lib.exports[symbol].stub) {`
`1318`	`1318`	dlSetError(`Tried to lookup unknown symbol "${symbol}" in dynamic lib: ${lib.name}`)
`1319`	`1319`	`return 0;`
`1320`	`1320`	`}`