Skip to content

Commit a2b1fdd

Browse files
authored
Remove skipTest from canvas_animate_resize. NFC (#24855)
Rather than magically skipping the test when OffscreenCanvas is not supported we should just fail. If folks want to run the whole test suite on a browser without such support we can add an `EMTEST_SKIP_OFFSCREEN_CANVAS` environment variable to control if/when these tests are run. I don't think this should be needed though since modern browsers all support `OffscreenCanvas`. See #24854
1 parent 03a8ee1 commit a2b1fdd

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

test/canvas_animate_resize.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -114,23 +114,15 @@ void init() {
114114
glLinkProgram(program);
115115
}
116116

117-
int main()
118-
{
117+
int main() {
119118
EmscriptenWebGLContextAttributes attr;
120119
emscripten_webgl_init_context_attributes(&attr);
121120
#if TEST_EXPLICIT_CONTEXT_SWAP
122121
attr.explicitSwapControl = true;
123122
#endif
124123
ctx = emscripten_webgl_create_context("#canvas", &attr);
125124
printf("Created context with handle %#lx\n", ctx);
126-
if (!ctx) {
127-
if (!emscripten_supports_offscreencanvas()) {
128-
EM_ASM({
129-
skipTest('OffscreenCanvas is not supported!');
130-
});
131-
}
132-
return 0;
133-
}
125+
assert(ctx);
134126
emscripten_webgl_make_context_current(ctx);
135127

136128
init();

0 commit comments

Comments
 (0)