Update node canary

This involved using toIndexType in a few more places due to recent
wasm64 changes requiring BitInt in more places.

Split out from #22773

Author: sbc100

.circleci/config.yml

@@ -106,7 +106,7 @@ commands:
     description: "install canary version of node"
     steps:
       - install-node-version:
-         node_version: "23.0.0-v8-canary20240819f52f1c2f1c"
+         node_version: "24.0.0-v8-canary202411045365c9d9be"
          canary: true
   install-v8:
     description: "install v8 using jsvu"

src/library.js

@@ -2344,6 +2344,10 @@ addToLibrary({
   'maximum': {{{ toIndexType(INITIAL_TABLE) }}},
 #endif
 #if MEMORY64 == 1
+  'address': 'i64',
+   // TODO(sbc): remove this alias for 'address' once both firefox and
+   // chrome roll out the spec change.
+   // See https://github.com/WebAssembly/memory64/pull/92
   'index': 'i64',
 #endif
   'element': 'anyfunc'

src/library_dylink.js

@@ -639,7 +639,7 @@ var LibraryDylink = {
         var memAlign = Math.pow(2, metadata.memoryAlign);
         // prepare memory
         var memoryBase = metadata.memorySize ? alignMemory(getMemory(metadata.memorySize + memAlign), memAlign) : 0; // TODO: add to cleanups
-        var tableBase = metadata.tableSize ? wasmTable.length : 0;
+        var tableBase = metadata.tableSize ? {{{ from64Expr('wasmTable.length') }}} : 0;
         if (handle) {
           {{{ makeSetValue('handle', C_STRUCTS.dso.mem_allocated, '1', 'i8') }}};
           {{{ makeSetValue('handle', C_STRUCTS.dso.mem_addr, 'memoryBase', '*') }}};
@@ -657,7 +657,7 @@ var LibraryDylink = {
 #if DYLINK_DEBUG
         dbg("loadModule: growing table: " + tableGrowthNeeded);
 #endif
-        wasmTable.grow(tableGrowthNeeded);
+        wasmTable.grow({{{ toIndexType('tableGrowthNeeded') }}});
       }
 #if DYLINK_DEBUG
       dbg("loadModule: memory[" + memoryBase + ":" + (memoryBase + metadata.memorySize) + "]" +

src/preamble.js

@@ -146,8 +146,6 @@ var HEAP,
 var HEAP_DATA_VIEW;
 #endif
 
-#include "runtime_shared.js"
-
 #if PTHREADS
 #include "runtime_pthread.js"
 #endif
@@ -588,7 +586,7 @@ function instrumentWasmTableWithAbort() {
   var realGet = wasmTable.get;
   var wrapperCache = {};
   wasmTable.get = (i) => {
-    var func = realGet.call(wasmTable, i);
+    var func = realGet.call(wasmTable, {{{ toIndexType('i') }}});
     var cached = wrapperCache[i];
     if (!cached || cached.func !== func) {
       cached = wrapperCache[i] = {

src/preamble_minimal.js

@@ -54,8 +54,6 @@ var HEAP8, HEAP16, HEAP32, HEAPU8, HEAPU16, HEAPU32, HEAPF32, HEAPF64,
 #endif
   wasmMemory;
 
-#include "runtime_shared.js"
-
 #if PTHREADS
 #include "runtime_pthread.js"
 #endif

src/shell.js

@@ -155,6 +155,8 @@ if (ENVIRONMENT_IS_NODE) {
 var ENVIRONMENT_IS_WASM_WORKER = Module['$ww'];
 #endif
 
+#include "runtime_shared.js"
+
 // --pre-jses are emitted after the Module integration code, so that they can
 // refer to Module (if they choose; they can also define Module)
 {{{ preJS() }}}

src/shell_minimal.js

@@ -162,6 +162,8 @@ if (ENVIRONMENT_IS_WORKER) {
 }
 #endif // PTHREADS
 
+#include "runtime_shared.js"
+
 // --pre-jses are emitted after the Module integration code, so that they can
 // refer to Module (if they choose; they can also define Module)
 {{{ preJS() }}}

test/core/test_module_wasm_memory.js

@@ -6,8 +6,14 @@
  * found in the LICENSE file.
  */
 
-Module['wasmMemory'] = new WebAssembly.Memory({ 'initial': 256, 'maximum': 256,
+Module['wasmMemory'] = new WebAssembly.Memory({
+  'initial': {{{ toIndexType('256') }}},
+  'maximum': {{{ toIndexType('256') }}},
 #if MEMORY64
-  'index': 'i64'
+  'address': 'i64',
+   // TODO(sbc): remove this alias for `address` once both firefox and
+   // chrome roll out the spec change.
+   // See https://github.com/WebAssembly/memory64/pull/92
+  'index': 'i64',
 #endif
 });