Skip to content

Commit a5e0710

Browse files
authored
Switch to Chrome Unstable with new Headless mode (#20069)
After Chrome updated, we can now use unstable/dev with new headless mode and all tests pass once more. Previously a Chrome update caused beta to fail with either old or new headless.
1 parent c65a321 commit a5e0710

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

.circleci/config.yml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,10 @@ commands:
4242
command: |
4343
# TODO: Make these part of the base image
4444
apt-get install libu2f-udev libvulkan1
45-
#wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
45+
# wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
4646
# If that download link breaks, temporarily use this URL instead:
47-
# TODO(sbc): Disable this once we figure out whats up with the
48-
# current beta.
49-
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
47+
# wget -O ~/chrome.deb https://storage.googleapis.com/webassembly/chrome/google-chrome-stable_current_amd64.deb
48+
wget -O ~/chrome.deb https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb
5049
dpkg -i ~/chrome.deb
5150
emsdk-env:
5251
description: "emsdk_env.sh"
@@ -350,7 +349,7 @@ commands:
350349
# --no-sandbox because we are running as root and chrome requires
351350
# this flag for now: https://crbug.com/638180
352351
CHROME_FLAGS_BASE: "--no-first-run -start-maximized --no-sandbox --use-gl=swiftshader --user-data-dir=/tmp/chrome-emscripten-profile --enable-experimental-web-platform-features"
353-
CHROME_FLAGS_HEADLESS: "--headless --remote-debugging-port=1234"
352+
CHROME_FLAGS_HEADLESS: "--headless=new --remote-debugging-port=1234"
354353
CHROME_FLAGS_WASM: "--enable-experimental-webassembly-features --js-flags=\"--experimental-wasm-memory64 --experimental-wasm-stack-switching --experimental-wasm-type-reflection\""
355354
CHROME_FLAGS_NOCACHE: "--disk-cache-dir=/dev/null --disk-cache-size=1 --media-cache-size=1 --disable-application-cache --incognito"
356355
command: |
@@ -359,11 +358,17 @@ commands:
359358
# that are not included by "./embuilder build ALL". For example the
360359
# PIC version of libSDL which is used by test_sdl2_misc_main_module
361360
export EM_FROZEN_CACHE=""
361+
echo
362+
echo "browser"
363+
echo
364+
# skip test_zzz_zzz_4gb_fail as it OOMs on the current bot
365+
test/runner browser skip:browser.test_zzz_zzz_4gb_fail skip:browser.test_zzz_zzz_4gb_fail_wasm64
366+
echo
367+
echo "emrun"
368+
echo
362369
# TODO(sbc): Re-enable once we figure out why the emrun tests are
363370
# locking up.
364371
# test/runner emrun
365-
# skip test_zzz_zzz_4gb_fail as it OOMs on the current bot
366-
test/runner posixtest_browser.test_pthread_create_1_1 browser skip:browser.test_zzz_zzz_4gb_fail skip:browser.test_zzz_zzz_4gb_fail_wasm64
367372
- upload-test-results
368373
test-sockets-chrome:
369374
description: "Runs emscripten sockets tests under chrome"
@@ -378,7 +383,7 @@ commands:
378383
# --no-sandbox becasue we are running as root and chrome requires
379384
# this flag for now: https://crbug.com/638180
380385
CHROME_FLAGS_BASE: "--no-first-run -start-maximized --no-sandbox --use-gl=swiftshader --user-data-dir=/tmp/chrome-emscripten-profile"
381-
CHROME_FLAGS_HEADLESS: "--headless --remote-debugging-port=1234"
386+
CHROME_FLAGS_HEADLESS: "--headless=new --remote-debugging-port=1234"
382387
CHROME_FLAGS_WASM: "--enable-experimental-webassembly-features --js-flags=\"--experimental-wasm-memory64\""
383388
CHROME_FLAGS_NOCACHE: "--disk-cache-dir=/dev/null --disk-cache-size=1 --media-cache-size=1 --disable-application-cache --incognito"
384389
command: |

0 commit comments

Comments
 (0)