Skip to content

Commit a623177

Browse files
authored
Add @requires_growable_arraybuffers decoration (#25470)
1 parent ac82bc4 commit a623177

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.circleci/config.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,6 +1096,8 @@ jobs:
10961096
test_targets: "browser64_4gb"
10971097
test-browser-firefox:
10981098
executor: focal
1099+
environment:
1100+
EMTEST_LACKS_GROWABLE_ARRAYBUFFERS: "1"
10991101
steps:
11001102
- prepare-for-tests
11011103
- run-tests-firefox:
@@ -1116,7 +1118,6 @@ jobs:
11161118
skip:browser.test_webgl_offscreen_canvas_in_pthread
11171119
skip:browser.test_webgl_offscreen_canvas_in_mainthread_after_pthread
11181120
skip:browser.test_glut_glutget
1119-
skip:browser.test_*_growable_arraybuffers
11201121
"
11211122
test-browser-firefox-wasm64:
11221123
executor: focal

test/test_browser.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ def webgpu_disabled():
191191
requires_sound_hardware = skipExecIf(os.getenv('EMTEST_LACKS_SOUND_HARDWARE'), 'This test requires sound hardware')
192192
requires_offscreen_canvas = unittest.skipIf(os.getenv('EMTEST_LACKS_OFFSCREEN_CANVAS'), 'This test requires a browser with OffscreenCanvas')
193193
requires_es6_workers = unittest.skipIf(os.getenv('EMTEST_LACKS_ES6_WORKERS'), 'This test requires a browser with ES6 Module Workers support')
194+
requires_growable_arraybuffers = unittest.skipIf(os.getenv('EMTEST_LACKS_GROWABLE_ARRAYBUFFERS'), 'This test requires a browser that supports growable ArrayBuffers')
194195

195196

196197
class browser(BrowserCore):
@@ -4688,6 +4689,7 @@ def test_minimal_runtime_hello_thread(self, opts):
46884689
})
46894690
@no_2gb('uses INITIAL_MEMORY')
46904691
@no_4gb('uses INITIAL_MEMORY')
4692+
@requires_growable_arraybuffers
46914693
def test_pthread_growth_mainthread(self, cflags, pthread_pool_size):
46924694
self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
46934695
if '-sGROWABLE_ARRAYBUFFERS' not in cflags:
@@ -4704,6 +4706,7 @@ def test_pthread_growth_mainthread(self, cflags, pthread_pool_size):
47044706
})
47054707
@no_2gb('uses INITIAL_MEMORY')
47064708
@no_4gb('uses INITIAL_MEMORY')
4709+
@requires_growable_arraybuffers
47074710
def test_pthread_growth(self, cflags, pthread_pool_size = 1):
47084711
self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
47094712
if '-sGROWABLE_ARRAYBUFFERS' not in cflags:

0 commit comments

Comments
 (0)