Skip to content

Commit a7427d8

Browse files
authored
[test] Simplify test_i64_val. NFC (#20239)
I made similar changes in #20073.
1 parent 143249e commit a7427d8

File tree

2 files changed

+8
-49
lines changed

2 files changed

+8
-49
lines changed

test/embind/test_i64_val.cpp

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,42 +6,21 @@
66
#include <stdio.h>
77
#include <iostream>
88
#include <sstream>
9-
#include <cmath>
109
#include <emscripten/bind.h>
1110
#include <emscripten/emscripten.h>
1211
#include <emscripten/val.h>
1312

1413
using namespace emscripten;
1514
using namespace std;
1615

17-
void fail()
18-
{
19-
cout << "fail\n";
20-
}
21-
22-
void pass()
23-
{
24-
cout << "pass\n";
25-
}
26-
27-
void test(string message)
28-
{
16+
void test(string message) {
2917
cout << "test:\n" << message << "\n";
3018
}
3119

32-
void ensure(bool value)
33-
{
34-
if (value)
35-
pass();
36-
else
37-
fail();
38-
}
39-
40-
void ensure_js(string js_code)
41-
{
20+
void ensure_js(string js_code) {
4221
js_code.append(";");
4322
const char* js_code_pointer = js_code.c_str();
44-
ensure(EM_ASM_INT({
23+
assert(EM_ASM_INT({
4524
var js_code = UTF8ToString($0);
4625
return eval(js_code);
4726
}, js_code_pointer));
@@ -54,8 +33,7 @@ string compare_a_64_js(T value) {
5433
return ss.str();
5534
}
5635

57-
int main()
58-
{
36+
int main() {
5937
const int64_t max_int64_t = numeric_limits<int64_t>::max();
6038
const int64_t min_int64_t = numeric_limits<int64_t>::min();
6139
const uint64_t max_uint64_t = numeric_limits<uint64_t>::max();
@@ -73,24 +51,24 @@ int main()
7351

7452
val::global().set("a", val(int64_t(0x12345678aabbccddL)));
7553
ensure_js("a === 1311768467732155613n");
76-
ensure(val::global()["a"].as<int64_t>() == 0x12345678aabbccddL);
54+
assert(val::global()["a"].as<int64_t>() == 0x12345678aabbccddL);
7755

7856
test("val(uint64_t v)");
7957
val::global().set("a", val(uint64_t(1234)));
8058
ensure_js("a === 1234n");
8159

8260
val::global().set("a", val(max_uint64_t));
8361
ensure_js(compare_a_64_js(max_uint64_t));
84-
ensure(val::global()["a"].as<uint64_t>() == max_uint64_t);
62+
assert(val::global()["a"].as<uint64_t>() == max_uint64_t);
8563

8664
test("val(int64_t v)");
8765
val::global().set("a", val(max_int64_t));
8866
ensure_js(compare_a_64_js(max_int64_t));
89-
ensure(val::global()["a"].as<int64_t>() == max_int64_t);
67+
assert(val::global()["a"].as<int64_t>() == max_int64_t);
9068

9169
val::global().set("a", val(min_int64_t));
9270
ensure_js(compare_a_64_js(min_int64_t));
93-
ensure(val::global()["a"].as<int64_t>() == min_int64_t);
71+
assert(val::global()["a"].as<int64_t>() == min_int64_t);
9472

9573
test("val(typed_memory_view<uint64_t>)");
9674
val::global().set("a", val(typed_memory_view(uint64Array.size(), uint64Array.data())));

test/embind/test_i64_val.out

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,12 @@
11
start
22
test:
33
val(int64_t v)
4-
pass
5-
pass
6-
pass
7-
pass
84
test:
95
val(uint64_t v)
10-
pass
11-
pass
12-
pass
136
test:
147
val(int64_t v)
15-
pass
16-
pass
17-
pass
18-
pass
198
test:
209
val(typed_memory_view<uint64_t>)
21-
pass
22-
pass
23-
pass
24-
pass
2510
test:
2611
val(typed_memory_view<int64_t>)
27-
pass
28-
pass
29-
pass
30-
pass
3112
end

0 commit comments

Comments
 (0)