Skip to content

Commit a7f4c56

Browse files
authored
[embind] Remove ancient jshint comments. NFC (#24520)
These comments were added together with Embind long, long time ago, but we don't use JSHint and our special library syntax wouldn't be compatible with it anyway, so the only thing they do is confuse devs who search for function usages.
1 parent a1179cf commit a7f4c56

File tree

2 files changed

+0
-35
lines changed

2 files changed

+0
-35
lines changed

src/lib/libembind.js

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,6 @@
33
// University of Illinois/NCSA Open Source License. Both these licenses can be
44
// found in the LICENSE file.
55

6-
/*global addToLibrary*/
7-
8-
/*global Module, asm*/
9-
/*global _malloc, _free, _memcpy*/
10-
/*global FUNCTION_TABLE, HEAP8, HEAPU8, HEAP16, HEAPU16, HEAP32, HEAPU32, HEAPF32, HEAPF64*/
11-
/*global AsciiToString*/
12-
/*global Emval, emval_handle_array, __emval_decref*/
13-
/*jslint sub:true*/ /* The symbols 'fromWireType' and 'toWireType' must be accessed via array notation to be closure-safe since craftInvokerFunction crafts functions as strings that can't be closured. */
14-
15-
// -- jshint doesn't understand library syntax, so we need to specifically tell it about the symbols we define
16-
/*global typeDependencies, flushPendingDeletes, getTypeName, getBasestPointer, throwBindingError, UnboundTypeError, embindRepr, registeredInstances, registeredTypes*/
17-
/*global ensureOverloadTable, embind__requireFunction, awaitingDependencies, makeLegalFunctionName, embind_charCodes:true, registerType, createNamedFunction, RegisteredPointer, throwInternalError*/
18-
/*global floatReadValueFromPointer, integerReadValueFromPointer, enumReadValueFromPointer, replacePublicSymbol, craftInvokerFunction, tupleRegistrations*/
19-
/*global finalizationRegistry, attachFinalizer, detachFinalizer, releaseClassHandle, runDestructor*/
20-
/*global ClassHandle, makeClassHandle, structRegistrations, whenDependentTypesAreResolved, BindingError, deletionQueue, delayFunction:true, upcastPointer*/
21-
/*global exposePublicSymbol, heap32VectorToArray, char_0, char_9*/
22-
/*global getInheritedInstanceCount, getLiveInheritedInstances, setDelayFunction, InternalError, runDestructors*/
23-
/*global requireRegisteredType, unregisterInheritedInstance, registerInheritedInstance, PureVirtualError, throwUnboundTypeError*/
24-
/*global assert, validateThis, downcastPointer, registeredPointers, RegisteredClass, getInheritedInstance */
25-
/*global throwInstanceAlreadyDeleted, shallowCopyInternalPointer*/
26-
/*global RegisteredPointer_fromWireType, constNoSmartPtrRawPointerToWireType, nonConstNoSmartPtrRawPointerToWireType, genericPointerToWireType*/
27-
286
#include "libembind_shared.js"
297

308
var LibraryEmbind = {

src/lib/libemval.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,6 @@
33
// University of Illinois/NCSA Open Source License. Both these licenses can be
44
// found in the LICENSE file.
55

6-
/*global Module:true, Runtime*/
7-
/*global HEAP32*/
8-
/*global createNamedFunction*/
9-
/*global AsciiToString, stringToUTF8*/
10-
/*global requireRegisteredType, throwBindingError, runDestructors*/
11-
/*jslint sub:true*/ /* The symbols 'fromWireType' and 'toWireType' must be accessed via array notation to be closure-safe since craftInvokerFunction crafts functions as strings that can't be closured. */
12-
13-
// -- jshint doesn't understand library syntax, so we need to mark the symbols exposed here
14-
/*global getStringOrSymbol, emval_freelist, emval_handles, Emval, __emval_unregister, count_emval_handles, emval_symbols, __emval_decref*/
15-
/*global emval_addMethodCaller, emval_methodCallers, addToLibrary, global, emval_lookupTypes, makeLegalFunctionName*/
16-
/*global emval_get_global*/
17-
186
// Number of handles reserved for non-use (0) or common values w/o refcount.
197
{{{
208
const EMVAL_RESERVED_HANDLES = 5;
@@ -170,7 +158,6 @@ var LibraryEmVal = {
170158
throw Error('unable to get global object.');
171159
},
172160
#else
173-
// appease jshint (technically this code uses eval)
174161
$emval_get_global: () => {
175162
if (typeof globalThis == 'object') {
176163
return globalThis;

0 commit comments

Comments
 (0)