Skip to content

Commit a9981ae

Browse files
authored
Fix crash with emrun --android + --browser (#17864)
Fixes: #17651
1 parent fd2c5f5 commit a9981ae

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

emrun.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1803,11 +1803,12 @@ def run(cmd):
18031803
# Workaround an issue where passing 'cmd /C start' is not able to detect
18041804
# when the user closes the page.
18051805
# serve_forever = True
1806-
global previous_browser_processes
1807-
logv(browser_exe)
1808-
previous_browser_processes = list_processes_by_name(browser_exe)
1809-
for p in previous_browser_processes:
1810-
logv('Before spawning web browser, found a running ' + os.path.basename(browser_exe) + ' browser process id: ' + str(p['pid']))
1806+
if browser_exe:
1807+
global previous_browser_processes
1808+
logv(browser_exe)
1809+
previous_browser_processes = list_processes_by_name(browser_exe)
1810+
for p in previous_browser_processes:
1811+
logv('Before spawning web browser, found a running ' + os.path.basename(browser_exe) + ' browser process id: ' + str(p['pid']))
18111812
browser_process = subprocess.Popen(browser, env=subprocess_env())
18121813
logv('Launched browser process with pid=' + str(browser_process.pid))
18131814
if options.kill_exit:

0 commit comments

Comments
 (0)