Skip to content

Commit b08c9f1

Browse files
authored
Remove dummy emscripten_set_offscreencanvas_size. NFC (#23279)
This is an internal-only API that is not directly callable by user code. The only place that this function is called is from `system/lib/html5/offscreencanvas.c` as a result of `_emscripten_set_offscreencanvas_size_on_thread`.
1 parent 8cb6dbf commit b08c9f1

File tree

4 files changed

+1
-15
lines changed

4 files changed

+1
-15
lines changed

src/library_html5.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2297,8 +2297,6 @@ var LibraryHTML5 = {
22972297
},
22982298

22992299
#if OFFSCREENCANVAS_SUPPORT
2300-
_emscripten_set_offscreencanvas_size: 'emscripten_set_canvas_element_size',
2301-
23022300
$setOffscreenCanvasSizeOnTargetThread__deps: ['$stringToNewUTF8', '_emscripten_set_offscreencanvas_size_on_thread'],
23032301
$setOffscreenCanvasSizeOnTargetThread: (targetThread, targetCanvas, width, height) => {
23042302
targetCanvas = targetCanvas ? UTF8ToString(targetCanvas) : '';
@@ -2414,15 +2412,6 @@ var LibraryHTML5 = {
24142412
},
24152413
#endif
24162414

2417-
#if !PTHREADS || !OFFSCREENCANVAS_SUPPORT
2418-
_emscripten_set_offscreencanvas_size: (target, width, height) => {
2419-
#if ASSERTIONS
2420-
err('emscripten_set_offscreencanvas_size: Build with -sOFFSCREENCANVAS_SUPPORT=1 to enable transferring canvases to pthreads.');
2421-
#endif
2422-
return {{{ cDefs.EMSCRIPTEN_RESULT_NOT_SUPPORTED }}};
2423-
},
2424-
#endif
2425-
24262415
// JavaScript-friendly API, returns pair [width, height]
24272416
$getCanvasElementSize__deps: ['emscripten_get_canvas_element_size', '$stackSave', '$stackRestore', '$stringToUTF8OnStack'],
24282417
$getCanvasElementSize: (target) => {

src/library_sigs.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ sigs = {
327327
_emscripten_push_uncounted_main_loop_blocker__sig: 'vppp',
328328
_emscripten_receive_on_main_thread_js__sig: 'dippip',
329329
_emscripten_runtime_keepalive_clear__sig: 'v',
330-
_emscripten_set_offscreencanvas_size__sig: 'ipii',
331330
_emscripten_system__sig: 'ip',
332331
_emscripten_thread_cleanup__sig: 'vp',
333332
_emscripten_thread_exit_joinable__sig: 'vp',

system/lib/html5/offscreencanvas.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ typedef struct set_cavas_size_t {
1010

1111
static void do_set_size(void* arg) {
1212
set_cavas_size_t* args = (set_cavas_size_t*)arg;
13-
_emscripten_set_offscreencanvas_size(args->target, args->width, args->height);
13+
emscripten_set_canvas_element_size(args->target, args->width, args->height);
1414
free((char *) args->target);
1515
free(arg);
1616
}

system/lib/libc/emscripten_internal.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,6 @@ size_t _emscripten_fetch_get_response_headers_length(int32_t fetchID);
139139
size_t _emscripten_fetch_get_response_headers(int32_t fetchID, char *dst, size_t dstSizeBytes);
140140
void emscripten_fetch_free(unsigned int);
141141

142-
EMSCRIPTEN_RESULT _emscripten_set_offscreencanvas_size(const char *target, int width, int height);
143-
144142
// Internal implementation function in JavaScript side that emscripten_create_wasm_worker() calls to
145143
// to perform the wasm worker creation.
146144
emscripten_wasm_worker_t _emscripten_create_wasm_worker(void *stackLowestAddress, uint32_t stackSize);

0 commit comments

Comments
 (0)