Merge branch 'remove_basic_string_unsigned_char' into update_libcxx_libcxxabi_19

Author: aheejin

test/embind/embind.test.js

@@ -449,33 +449,6 @@ module({
             assert.equal('ABCD', e);
         });
 
-        test("can pass Uint8Array to std::basic_string<unsigned char>", function() {
-            var e = cm.emval_test_take_and_return_std_basic_string_unsigned_char(new Uint8Array([65, 66, 67, 68]));
-            assert.equal('ABCD', e);
-        });
-
-        test("can pass long string to std::basic_string<unsigned char>", function() {
-            var s = 'this string is long enough to exceed the short string optimization';
-            var e = cm.emval_test_take_and_return_std_basic_string_unsigned_char(s);
-            assert.equal(s, e);
-        });
-
-        test("can pass Uint8ClampedArray to std::basic_string<unsigned char>", function() {
-            var e = cm.emval_test_take_and_return_std_basic_string_unsigned_char(new Uint8ClampedArray([65, 66, 67, 68]));
-            assert.equal('ABCD', e);
-        });
-
-
-        test("can pass Int8Array to std::basic_string<unsigned char>", function() {
-            var e = cm.emval_test_take_and_return_std_basic_string_unsigned_char(new Int8Array([65, 66, 67, 68]));
-            assert.equal('ABCD', e);
-        });
-
-        test("can pass ArrayBuffer to std::basic_string<unsigned char>", function() {
-            var e = cm.emval_test_take_and_return_std_basic_string_unsigned_char((new Int8Array([65, 66, 67, 68])).buffer);
-            assert.equal('ABCD', e);
-        });
-
         test("can pass string to std::string", function() {
             var string = stdStringIsUTF8?"aeiáéíαειЖЛФ從獅子€":"ABCD";
 

test/embind/embind_test.cpp

@@ -246,10 +246,6 @@ std::string emval_test_take_and_return_std_string_const_ref(const std::string& s
   return str;
 }
 
-std::basic_string<unsigned char> emval_test_take_and_return_std_basic_string_unsigned_char(std::basic_string<unsigned char> str) {
-  return str;
-}
-
 std::wstring take_and_return_std_wstring(std::wstring str) {
   return str;
 }
@@ -1914,7 +1910,6 @@ EMSCRIPTEN_BINDINGS(tests) {
   //function("emval_test_take_and_return_const_char_star", &emval_test_take_and_return_const_char_star);
   function("emval_test_take_and_return_std_string", &emval_test_take_and_return_std_string);
   function("emval_test_take_and_return_std_string_const_ref", &emval_test_take_and_return_std_string_const_ref);
-  function("emval_test_take_and_return_std_basic_string_unsigned_char", &emval_test_take_and_return_std_basic_string_unsigned_char);
   function("take_and_return_std_wstring", &take_and_return_std_wstring);
   function("take_and_return_std_u16string", &take_and_return_std_u16string);
   function("take_and_return_std_u32string", &take_and_return_std_u32string);