Review comments.

Author: brendandahl

ChangeLog.md

@@ -21,8 +21,8 @@ See docs/process.md for more on how version tagging works.
 3.1.68 (in development)
 -----------------------
 - The number of arguments passed to Embind function calls is now only verified
-  with ASSERTIONS enabled.
-- Optional arguments can now be omitted from Embind function calls.
+  with ASSERTIONS enabled. (#22591)
+- Optional arguments can now be omitted from Embind function calls. (#22591)
 
 3.1.67 - 09/17/24
 -----------------

src/embind/embind.js

@@ -58,8 +58,7 @@ var LibraryEmbind = {
     // emval is passed into JS via an interface
   }`,
   $EmValOptionalType__deps: ['$EmValType'],
-  $EmValOptionalType: undefined,
-  $EmValOptionalType__postset: 'EmValOptionalType = Object.assign({optional: true}, EmValType);',
+  $EmValOptionalType: '=Object.assign({optional: true}, EmValType);',
   $init_embind__deps: [
     '$getInheritedInstanceCount', '$getLiveInheritedInstances',
     '$flushPendingDeletes', '$setDelayFunction'],
@@ -783,8 +782,8 @@ var LibraryEmbind = {
     '$Asyncify',
 #endif
 #if ASSERTIONS
-  '$getRequiredArgCount',
-  '$checkArgCount',
+    '$getRequiredArgCount',
+    '$checkArgCount',
 #endif
   ],
   $craftInvokerFunction: function(humanName, argTypes, classType, cppInvokerFunc, cppTargetFunc, /** boolean= */ isAsync) {