Skip to content

Commit b47c44d

Browse files
authored
Update node canary. NFC (#23295)
As part of this change I verified that #21318 no longer effects that latest node canary and is also fixes in the latest chromium dev channel. Fixes: #21318
1 parent ff146f3 commit b47c44d

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ commands:
115115
description: "install canary version of node"
116116
steps:
117117
- install-node-version:
118-
node_version: "24.0.0-v8-canary202411045365c9d9be"
118+
node_version: "24.0.0-v8-canary202501036428a2737e"
119119
canary: true
120120
install-v8:
121121
description: "install v8 using jsvu"

test/test_browser.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3694,8 +3694,6 @@ def test_pthread_main_thread_blocking_join(self):
36943694
self.btest_exit('pthread/main_thread_join.cpp', args=['-O3', '-pthread', '-sPTHREAD_POOL_SIZE', '-sPROXY_TO_PTHREAD', '-sALLOW_BLOCKING_ON_MAIN_THREAD=0'])
36953695

36963696
# Test the old GCC atomic __sync_fetch_and_op builtin operations.
3697-
@no_2gb('https://github.com/emscripten-core/emscripten/issues/21318')
3698-
@no_4gb('https://github.com/emscripten-core/emscripten/issues/21318')
36993697
@parameterized({
37003698
'': (['-g'],),
37013699
'O1': (['-O1', '-g'],),
@@ -3709,8 +3707,6 @@ def test_pthread_gcc_atomic_fetch_and_op(self, args):
37093707

37103708
# 64 bit version of the above test.
37113709
@also_with_wasm2js
3712-
@no_2gb('https://github.com/emscripten-core/emscripten/issues/21318')
3713-
@no_4gb('https://github.com/emscripten-core/emscripten/issues/21318')
37143710
def test_pthread_gcc_64bit_atomic_fetch_and_op(self):
37153711
if self.is_wasm2js():
37163712
self.skipTest('https://github.com/WebAssembly/binaryen/issues/4358')
@@ -3719,16 +3715,12 @@ def test_pthread_gcc_64bit_atomic_fetch_and_op(self):
37193715

37203716
# Test the old GCC atomic __sync_op_and_fetch builtin operations.
37213717
@also_with_wasm2js
3722-
@no_2gb('https://github.com/emscripten-core/emscripten/issues/21318')
3723-
@no_4gb('https://github.com/emscripten-core/emscripten/issues/21318')
37243718
def test_pthread_gcc_atomic_op_and_fetch(self):
37253719
self.emcc_args += ['-Wno-sync-fetch-and-nand-semantics-changed']
37263720
self.btest_exit('pthread/test_pthread_gcc_atomic_op_and_fetch.c', args=['-O3', '-pthread', '-sPTHREAD_POOL_SIZE=8'])
37273721

37283722
# 64 bit version of the above test.
37293723
@also_with_wasm2js
3730-
@no_2gb('https://github.com/emscripten-core/emscripten/issues/21318')
3731-
@no_4gb('https://github.com/emscripten-core/emscripten/issues/21318')
37323724
def test_pthread_gcc_64bit_atomic_op_and_fetch(self):
37333725
if self.is_wasm2js():
37343726
self.skipTest('https://github.com/WebAssembly/binaryen/issues/4358')

0 commit comments

Comments
 (0)