Skip to content

Commit b4a32f4

Browse files
authored
Remove double-logging of sub-commands. NFC (#25478)
The `check_call` function already does `print_compiler_stage`.
1 parent d21ef58 commit b4a32f4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tools/building.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work
378378
if settings.VERBOSE:
379379
cmd += ['--verbose']
380380
if return_output:
381-
shared.print_compiler_stage(cmd)
382381
if shared.SKIP_SUBPROCS:
382+
shared.print_compiler_stage(cmd)
383383
return ''
384384
return check_call(cmd, stdout=PIPE).stdout
385385

@@ -390,8 +390,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work
390390
output_file = basename + '.jso%d.js' % acorn_optimizer.counter
391391
shared.get_temp_files().note(output_file)
392392
cmd += ['-o', output_file]
393-
shared.print_compiler_stage(cmd)
394393
if shared.SKIP_SUBPROCS:
394+
shared.print_compiler_stage(cmd)
395395
return output_file
396396
check_call(cmd)
397397
save_intermediate(output_file, '%s.js' % passes[0])
@@ -1245,8 +1245,8 @@ def run_binaryen_command(tool, infile, outfile=None, args=None, debug=False, std
12451245
if settings.GENERATE_SOURCE_MAP and outfile and tool in ['wasm-opt', 'wasm-emscripten-finalize', 'wasm-metadce']:
12461246
cmd += [f'--input-source-map={infile}.map']
12471247
cmd += [f'--output-source-map={outfile}.map']
1248-
shared.print_compiler_stage(cmd)
12491248
if shared.SKIP_SUBPROCS:
1249+
shared.print_compiler_stage(cmd)
12501250
return ''
12511251
ret = check_call(cmd, stdout=stdout).stdout
12521252
if outfile:

0 commit comments

Comments
 (0)