Skip to content

Commit b70f2d4

Browse files
authored
Remove some unnecessary use of Path.resolve(). NFC (#25488)
It looks like this was first introduced in #17102 as a replacement for `os.path.normpath`, but its not actually same thing `os.path.normpath` does not resolve symlinks. Apparently resolving symlinks can actually cause crashes on windows in some cases. See #25463. Fixes: #25463
1 parent 9bc3ffa commit b70f2d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

site/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
# |version| and |release|, also used in various other places throughout the
9898
# built documents.
9999
#
100-
version_path = Path(os.path.dirname(os.path.dirname(os.path.dirname(__file__))), 'emscripten-version.txt').resolve()
100+
version_path = Path(os.path.dirname(os.path.dirname(os.path.dirname(__file__))), 'emscripten-version.txt')
101101
emscripten_version = version_path.read_text().strip().strip('"')
102102

103103
# The short X.Y version.

tools/cache.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def get(shortname, creator, what=None, force=False, quiet=False):
194194
def setup():
195195
global cachedir, cachelock, cachelock_name
196196
# figure out the root directory for all caching
197-
cachedir = Path(config.CACHE).resolve()
197+
cachedir = Path(config.CACHE)
198198

199199
# since the lock itself lives inside the cache directory we need to ensure it
200200
# exists.

0 commit comments

Comments
 (0)