Skip to content

Commit b95a669

Browse files
authored
Remove path.normalize from node file reading code. NFC (#23087)
I don't see any reason to perform normalization here. The file read operations will happily accept relative paths and resolve them internally.
1 parent c028edb commit b95a669

File tree

82 files changed

+84
-85
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+84
-85
lines changed

src/node_shell_read.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
*/
66

77
readBinary = (filename) => {
8-
// We need to re-wrap `file://` strings to URLs. Normalizing isn't
9-
// necessary in that case, the path should already be absolute.
10-
filename = isFileURI(filename) ? new URL(filename) : nodePath.normalize(filename);
8+
// We need to re-wrap `file://` strings to URLs.
9+
filename = isFileURI(filename) ? new URL(filename) : filename;
1110
var ret = fs.readFileSync(filename);
1211
#if ASSERTIONS
1312
assert(ret.buffer);
@@ -17,7 +16,7 @@ readBinary = (filename) => {
1716

1817
readAsync = (filename, binary = true) => {
1918
// See the comment in the `readBinary` function.
20-
filename = isFileURI(filename) ? new URL(filename) : nodePath.normalize(filename);
19+
filename = isFileURI(filename) ? new URL(filename) : filename;
2120
return new Promise((resolve, reject) => {
2221
fs.readFile(filename, binary ? undefined : 'utf8', (err, data) => {
2322
if (err) reject(err);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8534
1+
8520
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20856
1+
20825
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8518
1+
8504
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20824
1+
20793
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
9563
1+
9550
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
24699
1+
24668
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8500
1+
8489
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20750
1+
20718
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8500
1+
8489

0 commit comments

Comments
 (0)