Address review comments

Author: cclauss

tools/emscripten.py

@@ -704,7 +704,7 @@ def create_asm_consts(metadata):
     for i in range(max_arity):
       if f'${i}' in const:
         arity = i + 1
-    args = ', '.join(f"${i}" for i in range(arity))
+    args = ', '.join(f'${i}' for i in range(arity))
     if 'arguments' in body:
       # arrow functions don't bind `arguments` so we have to use
       # the old function syntax in this case

tools/feature_matrix.py

@@ -106,16 +106,16 @@ def report_missing(setting_name):
     setting_value = getattr(settings, setting_name)
     logger.debug(f'cannot use {feature.name} because {setting_name} is too old: {setting_value}')
 
-  if min_versions['chrome'] > settings.MIN_CHROME_VERSION:
+  if settings.MIN_CHROME_VERSION < min_versions['chrome']:
     report_missing('MIN_CHROME_VERSION')
     return False
-  if min_versions['firefox'] > settings.MIN_FIREFOX_VERSION:
+  if settings.MIN_FIREFOX_VERSION < min_versions['firefox']:
     report_missing('MIN_FIREFOX_VERSION')
     return False
-  if min_versions['safari'] > settings.MIN_SAFARI_VERSION:
+  if settings.MIN_SAFARI_VERSION < min_versions['safari']:
     report_missing('MIN_SAFARI_VERSION')
     return False
-  if 'node' in min_versions and min_versions['node'] > settings.MIN_NODE_VERSION:
+  if 'node' in min_versions and settings.MIN_NODE_VERSION < min_versions['node']:
     report_missing('MIN_NODE_VERSION')
     return False
   return True

tools/toolchain_profiler.py

@@ -152,7 +152,7 @@ def escape_string(arg):
 
     @staticmethod
     def escape_args(args):
-      return (ToolchainProfiler.escape_string(arg) for arg in args)
+      return [ToolchainProfiler.escape_string(arg) for arg in args]
 
     @staticmethod
     def record_process_start(write_log_entry=True):