Skip to content

Commit c12ec5b

Browse files
authored
makeSetValue: Remove references to long-unused args. NFC (#19257)
My hope is that we can move to an options bag instead of positional arguments if we do want to consider adding more options in the figure.
1 parent 6791b1c commit c12ec5b

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/parseTools.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -354,18 +354,11 @@ function makeGetValue(ptr, pos, type, noNeedFirst, unsigned, ignore, align) {
354354
* @param {number} value The value to set.
355355
* @param {string} type A string defining the type. Used to find the slab (HEAPU8, HEAP16, HEAPU32, etc.).
356356
* which means we should write to all slabs, ignore type differences if any on reads, etc.
357-
* @param {bool} noNeedFirst Whether to ignore the offset in the pointer itself.
358-
* @param {bool} ignore: legacy, ignored.
359-
* @param {number} align: legacy, ignored.
360-
* @param {string} sep: legacy, ignored.
361-
* @return {TODO}
357+
* @return {string} JS code for performing the memory set operation
362358
*/
363-
function makeSetValue(ptr, pos, value, type, noNeedFirst, ignore, align, sep) {
364-
assert(typeof align === 'undefined', 'makeSetValue no longer supports align parameter');
365-
assert(typeof noNeedFirst === 'undefined', 'makeSetValue no longer supports noNeedFirst parameter');
366-
assert(typeof sep === 'undefined', 'makeSetValue no longer supports sep parameter');
359+
function makeSetValue(ptr, pos, value, type) {
367360
if (type == 'i64' && !WASM_BIGINT) {
368-
// If we lack either BigInt we must fall back to an reading a pair of I32
361+
// If we lack BigInt support we must fall back to an reading a pair of I32
369362
// values.
370363
return '(tempI64 = [' + splitI64(value) + '], ' +
371364
makeSetValue(ptr, pos, 'tempI64[0]', 'i32') + ',' +

0 commit comments

Comments
 (0)