[eslint] Enable all recommended rules. NFC (#23431)

Author: sbc100

eslint.config.mjs

@@ -52,6 +52,8 @@ export default [{
     'src/Fetch.js',
     'src/settings.js',
     'src/settings_internal.js',
+    'src/growableHeap.js',
+    'src/emrun_prejs.js',
     'src/arrayUtils.js',
     'src/deterministic.js',
     'src/base64Decode.js',
@@ -61,7 +63,7 @@ export default [{
     'src/URIUtils.js',
     'tools/experimental',
   ],
-}, ...compat.extends('prettier'), {
+}, ...compat.extends('prettier'), js.configs.recommended, {
   languageOptions: {
     globals: {
       ...globals.browser,
@@ -79,6 +81,7 @@ export default [{
     'require-jsdoc': 'off',
     'arrow-body-style': ['error', 'as-needed'],
     'space-infix-ops': 'error',
+    'no-prototype-builtins': 'off',
 
     quotes: ['error', 'single', {
       avoidEscape: true,

tools/acorn-optimizer.mjs

@@ -457,7 +457,7 @@ function JSDCE(ast, aggressive) {
     cleanUp(ast, names);
     return removed;
   }
-  while (iteration() && aggressive) {}
+  while (iteration() && aggressive) {} // eslint-disable-line no-empty
 }
 
 // Aggressive JSDCE - multiple iterations
@@ -1275,8 +1275,6 @@ function growableHeap(ast) {
             makeCallExpression(node, 'GROWABLE_HEAP_F64', []);
             break;
           }
-          default: {
-          }
         }
       }
     },
@@ -1419,8 +1417,6 @@ function asanify(ast) {
             makeCallExpression(node, '_asan_js_store_d', [ptr, value]);
             break;
           }
-          default: {
-          }
         }
       } else {
         c(target);
@@ -1466,8 +1462,6 @@ function asanify(ast) {
             makeCallExpression(node, '_asan_js_load_d', [ptr]);
             break;
           }
-          default: {
-          }
         }
       }
     },
@@ -1615,8 +1609,6 @@ function safeHeap(ast) {
             ]);
             break;
           }
-          default: {
-          }
         }
       }
     },
@@ -1660,7 +1652,7 @@ function ensureMinifiedNames(n) {
     if (!RESERVED.has(name)) minifiedNames.push(name);
     // increment the state
     let i = 0;
-    while (1) {
+    while (true) {
       minifiedState[i]++;
       if (minifiedState[i] < (i === 0 ? VALID_MIN_INITS : VALID_MIN_LATERS).length) break;
       // overflow
@@ -1739,7 +1731,7 @@ function minifyLocals(ast) {
     let nextMinifiedName = 0;
 
     function getNextMinifiedName() {
-      while (1) {
+      while (true) {
         ensureMinifiedNames(nextMinifiedName);
         const minified = minifiedNames[nextMinifiedName++];
         // TODO: we can probably remove !isLocalName here