[embind] Fix type in overloadTable error checking. NFC

sbc100 · sbc100 · commit c76d12d4cc39 · 2024-10-10T14:10:40.000-07:00
diff --git a/src/embind/embind.js b/src/embind/embind.js
@@ -124,7 +124,7 @@ var LibraryEmbind = {
       // We are exposing a function with the same name as an existing function. Create an overload table and a function selector
       // that routes between the two.
       ensureOverloadTable(Module, name, name);
-      if (Module.hasOwnProperty(numArguments)) {
+      if (Module[name].overloadTable.hasOwnProperty(numArguments)) {
         throwBindingError(`Cannot register multiple overloads of a function with the same number of arguments (${numArguments})!`);
       }
       // Add the new function into the overload table.

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ var LibraryEmbind = {`
`124`	`124`	`// We are exposing a function with the same name as an existing function. Create an overload table and a function selector`
`125`	`125`	`// that routes between the two.`
`126`	`126`	`ensureOverloadTable(Module, name, name);`
`127`		`- if (Module.hasOwnProperty(numArguments)) {`
	`127`	`+ if (Module[name].overloadTable.hasOwnProperty(numArguments)) {`
`128`	`128`	throwBindingError(`Cannot register multiple overloads of a function with the same number of arguments (${numArguments})!`);
`129`	`129`	`}`
`130`	`130`	`// Add the new function into the overload table.`