Skip to content

Commit cbcda4b

Browse files
authored
Don't export 'run' runtime method by default (#17383)
Instead allow folks to export it via EXPORTED_RUNTIME_METHODS, just other similar functions such as `abort`. See #9334 and 4ccf542
1 parent 48dcf17 commit cbcda4b

35 files changed

+35
-33
lines changed

ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ See docs/process.md for more on how version tagging works.
3434
explictly required. Exporting them via `EXPORTED_RUNTIME_METHODS` will
3535
continue to work. For internal usage (without exporting them) they can be
3636
added to `DEFAULT_LIBRARY_FUNCS_TO_INCLUDE`. (#17370)
37+
- The `run` runtime function is no longer exported by default. It can be added
38+
to `EXPORTED_RUNTIME_METHODS` if needed.
3739

3840
3.1.15 - 07/01/2022
3941
-------------------

src/modules.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,7 @@ function exportRuntime() {
471471
if (!MINIMAL_RUNTIME) {
472472
// MINIMAL_RUNTIME has moved these functions to library_strings.js
473473
runtimeElements = runtimeElements.concat([
474+
'run',
474475
'warnOnce',
475476
'stackSave',
476477
'stackRestore',

src/postamble.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,6 @@ function run(args) {
355355
checkStackCookie();
356356
#endif
357357
}
358-
Module['run'] = run;
359358

360359
#if ASSERTIONS
361360
#if EXIT_RUNTIME == 0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
26211
1+
26202
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
26175
1+
26166
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
31605
1+
31596
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
26365
1+
26356
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
31705
1+
31696
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
26211
1+
26202
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
26693
1+
26698

0 commit comments

Comments
 (0)