[pthreads] Handle exit exceptions during pthread cleanup. (#24711)

Thread cleanup can potentially execute the queue mailbox and trigger an
ExitStatus exception, so we must wrap cleanup with callUserCallback to
handle the exception or node will complain about an unhandled exception.

Fixes #24500,  #22490

Author: brendandahl

src/lib/libpthread.js

@@ -251,7 +251,10 @@ var LibraryPThread = {
         } else if (cmd === 'spawnThread') {
           spawnThread(d);
         } else if (cmd === 'cleanupThread') {
-          cleanupThread(d.thread);
+          // cleanupThread needs to be run via callUserCallback since it calls
+          // back into user code to free thread data. Without this it's possible
+          // the unwind or ExitStatus exception could escape here.
+          callUserCallback(() => cleanupThread(d.thread));
 #if MAIN_MODULE
         } else if (cmd === 'markAsFinished') {
           markAsFinished(d.thread);

test/other/codesize/test_codesize_minimal_pthreads.gzsize

@@ -1 +1 @@
-3735
+3745

test/other/codesize/test_codesize_minimal_pthreads.jssize

@@ -1 +1 @@
-7615
+7635

test/other/codesize/test_codesize_minimal_pthreads_memgrowth.gzsize

@@ -1 +1 @@
-3941
+3949

test/other/codesize/test_codesize_minimal_pthreads_memgrowth.jssize

@@ -1 +1 @@
-8046
+8066

test/test_core.py

@@ -9185,7 +9185,6 @@ def test_pthread_create(self):
     self.set_setting('STRICT')
     self.do_core_test('pthread/create.c')
 
-  @flaky('https://github.com/emscripten-core/emscripten/issues/22617')
   @node_pthreads
   @parameterized({
     '': ([],),

test/test_other.py

@@ -2151,7 +2151,6 @@ def test(link_flags, lib_suffix):
 
   @node_pthreads
   @also_with_modularize
-  @flaky('https://github.com/emscripten-core/emscripten/issues/24500')
   def test_dylink_pthread_static_data(self):
     # Test that a side module uses the same static data region for global objects across all threads