[MODULARIZE=instance] Mark file packager as incompatible for now. (#24338)

Author: sbc100

site/source/docs/compiling/Modularized-Output.rst

@@ -125,6 +125,8 @@ fix in future releses.  Current limitations include:
 * :ref:`abort_on_wasm_exceptions` is not supported (requires wrapping wasm
   exports).
 
+* The output of file_packager is not compatible so :ref:`emcc-preload-file` and
+  :ref:`emcc-embed-file` do not work.
 
 Source Phase Imports (experimental)
 ===================================

test/test_core.py

@@ -3910,6 +3910,7 @@ def test_dlfcn_rtld_local(self):
     self.do_runf('main.c', 'main\nfunc_a\nfunc_sub\nfunc_b\nfunc_sub\ndone\n')
 
   @needs_dylink
+  @no_modularize_instance('uses file packager')
   def test_dlfcn_preload(self):
     # Create chain of dependencies and load the first libary with preload plugin.
     # main -> libb.so -> liba.so

tools/link.py

@@ -794,8 +794,8 @@ def phase_linker_setup(options, linker_args):  # noqa: C901, PLR0912, PLR0915
   if settings.WASM_ESM_INTEGRATION:
     diagnostics.warning('experimental', '-sWASM_ESM_INTEGRATION is still experimental and not yet supported in browsers')
     default_setting('MODULARIZE', 'instance')
-    if options.oformat != OFormat.MJS:
-      exit_with_error('WASM_ESM_INTEGRATION is only compatible with EM module output format')
+    if not settings.EXPORT_ES6:
+      exit_with_error('WASM_ESM_INTEGRATION requires EXPORT_ES6')
     if settings.MODULARIZE != 'instance':
       exit_with_error('WASM_ESM_INTEGRATION requires MODULARIZE=instance')
     if settings.RELOCATABLE:
@@ -813,10 +813,12 @@ def limit_incoming_module_api():
 
   if settings.MODULARIZE == 'instance':
     diagnostics.warning('experimental', 'MODULARIZE=instance is still experimental. Many features may not work or will change.')
-    if options.oformat != OFormat.MJS:
-      exit_with_error('MODULARIZE=instance is only compatible with ES module output format')
+    if not settings.EXPORT_ES6:
+      exit_with_error('MODULARIZE=instance requires EXPORT_ES6')
     if settings.ABORT_ON_WASM_EXCEPTIONS:
       exit_with_error('MODULARIZE=instance is only compatible with ABORT_ON_WASM_EXCEPTIONS')
+    if options.use_preload_plugins or len(options.preload_files):
+      exit_with_error('MODULARIZE=instance is not compatile with --embed-file/--preload-file')
     if 'INCOMING_MODULE_JS_API' in user_settings:
       for s in ['wasmMemory', 'INITIAL_MEMORY']:
         if s in settings.INCOMING_MODULE_JS_API: