ruff --ignore=SIM108

Author: cclauss

tools/building.py

@@ -425,7 +425,10 @@ def eval_ctors(js_file, wasm_file, debug_info):
     if kept_ctors:
       args += ['--kept-exports=' + ','.join(kept_ctors)]
   else:
-    ctor = '_start' if settings.EXPECT_MAIN else '_initialize'
+    if settings.EXPECT_MAIN:
+      ctor = '_start'
+    else:
+      ctor = '_initialize'
     args = ['--ctors=' + ctor, '--kept-exports=' + ctor]
   if settings.EVAL_CTORS == 2:
     args += ['--ignore-external-input']

tools/emscripten.py

@@ -346,7 +346,10 @@ def emscript(in_wasm, out_wasm, outfile_js, js_syms, finalize=True, base_metadat
 
     for em_js_func, raw in metadata.em_js_funcs.items():
       c_sig = raw.split('<::>')[0].strip('()')
-      c_sig = [] if (c_sig or 'void') == 'void' else c_sig.split(',')
+      if not c_sig or c_sig == 'void':
+        c_sig = []
+      else:
+        c_sig = c_sig.split(',')
       if em_js_func in import_map:
         imp = import_map[em_js_func]
         assert imp.kind == webassembly.ExternType.FUNC
@@ -643,8 +646,11 @@ def create_tsd_exported_runtime_methods(metadata):
   tsc_output_file = in_temp('jsdoc.d.ts')
   utils.write_file(js_doc_file, js_doc)
   tsc = shutil.which('tsc')
-  # Use the full path from the which command so windows can find tsc.
-  tsc = [tsc] if tsc else shared.get_npm_cmd('tsc')
+  if tsc:
+    # Use the full path from the which command so windows can find tsc.
+    tsc = [tsc]
+  else:
+    tsc = shared.get_npm_cmd('tsc')
   cmd = tsc + ['--outFile', tsc_output_file, '--declaration', '--emitDeclarationOnly', '--allowJs', js_doc_file]
   shared.check_call(cmd, cwd=path_from_root())
   return utils.read_file(tsc_output_file)
@@ -752,7 +758,10 @@ def create_em_js(metadata):
     assert separator in raw
     args, body = raw.split(separator, 1)
     args = args[1:-1]
-    args = [] if args == 'void' else args.split(',')
+    if args == 'void':
+      args = []
+    else:
+      args = args.split(',')
     arg_names = [arg.split()[-1].replace('*', '') for arg in args if arg]
     args = ','.join(arg_names)
     func = f'function {name}({args}) {body}'

tools/maint/gen_struct_info.py

@@ -242,7 +242,10 @@ def generate_cmd(js_file_path, src_file_path, cflags):
   # Compile the program.
   show('Compiling generated code...')
 
-  compiler = shared.EMXX if any('libcxxabi' in f for f in cflags) else shared.EMCC
+  if any('libcxxabi' in f for f in cflags):
+    compiler = shared.EMXX
+  else:
+    compiler = shared.EMCC
 
   node_flags = building.get_emcc_node_flags(shared.check_node_version())
 

tools/minimal_runtime_shell.py

@@ -159,7 +159,10 @@ def generate_minimal_runtime_load_statement(target_basename):
     else:
       script_load = "script(url).then(() => URL.revokeObjectURL(url));"
 
-    save_js = f'{settings.EXPORT_NAME}.js = ' if settings.WASM_WORKERS else ''
+    if settings.WASM_WORKERS:
+      save_js = f'{settings.EXPORT_NAME}.js = '
+    else:
+      save_js = ''
 
     files_to_load[0] = f"binary('{target_basename}.js')"
     if not settings.MODULARIZE:

tools/system_libs.py

@@ -502,7 +502,10 @@ def build_objects(self, build_dir):
     case_insensitive = is_case_insensitive(build_dir)
     for src in self.get_files():
       ext = shared.suffix(src)
-      cmd = shared.EMCC if ext in {'.s', '.S', '.c'} else shared.EMXX
+      if ext in {'.s', '.S', '.c'}:
+        cmd = shared.EMCC 
+      else:
+        cmd = shared.EMXX
       cmd = [cmd, '-c']
       if ext == '.s':
         # .s files are processed directly by the assembler.  In this case we can't pass

tools/webassembly.py

@@ -486,7 +486,10 @@ def get_segments(self):
     num_segments = self.read_uleb()
     for _ in range(num_segments):
       flags = self.read_uleb()
-      init = None if flags & SEG_PASSIVE else self.read_init()
+      if (flags & SEG_PASSIVE):
+        init = None
+      else:
+        init = self.read_init()
       size = self.read_uleb()
       offset = self.tell()
       segments.append(DataSegment(flags, init, offset, size))

tools/webidl_binder.py

@@ -438,7 +438,10 @@ def render_function(class_name, func_name, sigs, return_type, non_pointer,
   args = [(all_args[i].identifier.name if isinstance(all_args[i], WebIDL.IDLArgument) else ('arg%d' % i)) for i in range(max_args)]
   if not constructor and not is_static:
     body = '  var self = this.ptr;\n'
-    pre_arg = ['BigInt(self)'] if options.wasm64 else ['self']
+    if options.wasm64:
+      pre_arg = ['BigInt(self)']
+    else:
+      pre_arg = ['self']
   else:
     body = ''
     pre_arg = []
@@ -457,10 +460,16 @@ def is_ptr_arg(i):
     compatible_arg = isinstance(arg, Dummy) or (isinstance(arg, WebIDL.IDLArgument) and arg.optional is False)
     # note: null has typeof object, but is ok to leave as is, since we are calling into asm code where null|0 = 0
     if not legacy_mode and compatible_arg:
-      arg_name = arg.identifier.name if isinstance(arg, WebIDL.IDLArgument) else ''
+      if isinstance(arg, WebIDL.IDLArgument):
+        arg_name = arg.identifier.name
+      else:
+        arg_name = ''
       # Format assert fail message
       check_msg = "[CHECK FAILED] %s::%s(%s:%s): " % (class_name, func_name, js_arg, arg_name)
-      inner = arg.type.inner if isinstance(arg.type, WebIDL.IDLWrapperType) else ''
+      if isinstance(arg.type, WebIDL.IDLWrapperType):
+        inner = arg.type.inner
+      else:
+        inner = ""
 
       # Print type info in comments.
       body += "  /* %s <%s> [%s] */\n" % (js_arg, arg.type.name, inner)
@@ -539,7 +548,10 @@ def make_call_args(i):
 
   for i in range(min_args, max_args):
     c_names[i] = f'emscripten_bind_{bindings_name}_{i}'
-    after_call = '' if 'return ' in call_prefix else f'; {cache}return'
+    if 'return ' in call_prefix:
+      after_call = ''
+    else:
+      after_call = '; ' + cache + 'return'
     args_for_call = make_call_args(i)
     body += '  if (%s === undefined) { %s_%s(%s)%s%s }\n' % (args[i], call_prefix, c_names[i],
                                                              args_for_call,
@@ -551,7 +563,10 @@ def make_call_args(i):
   if cache:
     body += f'  {cache}\n'
 
-  declare_name = f' {func_name}' if constructor else ''
+  if constructor:
+    declare_name = ' ' + func_name
+  else:
+    declare_name = ''
   mid_js.append(r'''function%s(%s) {
 %s
 };
@@ -586,8 +601,11 @@ def make_call_args(i):
     else:
       if not bind_to:
         bind_to = func_name
-      call = f'{bind_to}({call_args})'
-      call = f'{c_class_name}::{call}' if is_static else f'self->{call}'
+      call = bind_to + '(' + call_args + ')'
+      if is_static:
+        call = c_class_name + '::' + call
+      else:
+        call = 'self->' + call
 
     if operator:
       cast_self = 'self'