Optimize ENVIRONMENT_IS_AUDIO_WORKLET checks (#25351)

Optimize ENVIRONMENT_IS_AUDIO_WORKLET checks and use it in more places
to optimize code size.

Author: juj

src/lib/libwasm_worker.js

@@ -26,7 +26,7 @@
 #endif
 
 {{{
-  const workerSupportsFutexWait = () => AUDIO_WORKLET ? "typeof AudioWorkletGlobalScope === 'undefined'" : '1';
+  const workerSupportsFutexWait = () => AUDIO_WORKLET ? "!ENVIRONMENT_IS_AUDIO_WORKLET" : '1';
   const wasmWorkerJs = `
 #if MINIMAL_RUNTIME
 #if ENVIRONMENT_MAY_BE_NODE
@@ -146,7 +146,7 @@ addToLibrary({
 
 #if AUDIO_WORKLET
     // Audio Worklets do not have postMessage()ing capabilities.
-    if (typeof AudioWorkletGlobalScope === 'undefined') {
+    if (!ENVIRONMENT_IS_AUDIO_WORKLET) {
 #endif
       // The Wasm Worker runtime is now up, so we can start processing
       // any postMessage function calls that have been received. Drop the temp

src/lib/libwebaudio.js

@@ -316,7 +316,7 @@ var LibraryWebAudio = {
     srcNode.connect(dstNode.destination || dstNode, outputIndex, inputIndex);
   },
 
-  emscripten_current_thread_is_audio_worklet: () => typeof AudioWorkletGlobalScope !== 'undefined',
+  emscripten_current_thread_is_audio_worklet: () => ENVIRONMENT_IS_AUDIO_WORKLET,
 
   emscripten_audio_worklet_post_function_v: (audioContext, funcPtr) => {
     (audioContext ? EmAudio[audioContext].audioWorklet.bootstrapMessage.port : messagePort).postMessage({'_wsc': funcPtr, args: [] }); // "WaSm Call"

src/shell.js

@@ -51,7 +51,7 @@ var ENVIRONMENT_IS_WASM_WORKER = globalThis.name == 'em-ww';
 #endif
 
 #if AUDIO_WORKLET
-var ENVIRONMENT_IS_AUDIO_WORKLET = typeof AudioWorkletGlobalScope !== 'undefined';
+var ENVIRONMENT_IS_AUDIO_WORKLET = !!globalThis.AudioWorkletGlobalScope;
 // Audio worklets behave as wasm workers.
 if (ENVIRONMENT_IS_AUDIO_WORKLET) ENVIRONMENT_IS_WASM_WORKER = true;
 #endif

src/shell_minimal.js

@@ -71,7 +71,7 @@ if (ENVIRONMENT_IS_NODE) {
 #endif
 
 #if AUDIO_WORKLET
-var ENVIRONMENT_IS_AUDIO_WORKLET = typeof AudioWorkletGlobalScope !== 'undefined';
+var ENVIRONMENT_IS_AUDIO_WORKLET = !!globalThis.AudioWorkletGlobalScope;
 if (ENVIRONMENT_IS_AUDIO_WORKLET) ENVIRONMENT_IS_WASM_WORKER = true;
 #endif
 

test/codesize/audio_worklet_wasm.js

@@ -1,4 +1,4 @@
-var m = globalThis.Module || "undefined" != typeof Module ? Module : {}, n = "em-ww" == globalThis.name, q = "undefined" !== typeof AudioWorkletGlobalScope, t, z, J, K, H, E, v, X, F, C, B, Y, A, Z;
+var m = globalThis.Module || "undefined" != typeof Module ? Module : {}, n = "em-ww" == globalThis.name, q = !!globalThis.AudioWorkletGlobalScope, t, z, J, K, H, D, v, X, F, C, B, Y, A, Z;
 
 q && (n = !0);
 
@@ -31,7 +31,7 @@ if (q) {
                 this.K();
             }
             K() {
-                for (var d = B(), f = C(this.B.length * this.s) >> 2, g = this.B.length - 1; 0 <= g; g--) this.B[g] = E.subarray(f, f += this.u);
+                for (var d = B(), f = C(this.B.length * this.s) >> 2, g = this.B.length - 1; 0 <= g; g--) this.B[g] = D.subarray(f, f += this.u);
                 F(d);
             }
             static get parameterDescriptors() {
@@ -46,24 +46,24 @@ if (q) {
                 l += G * this.s;
                 var O = 0;
                 for (k in g) ++O, h += 8, l += g[k].byteLength;
-                var V = B(), D = h + l + 15 & -16;
-                h = C(D);
-                l = h + (D - l);
-                D = h;
+                var V = B(), E = h + l + 15 & -16;
+                h = C(E);
+                l = h + (E - l);
+                E = h;
                 for (k of d) {
                     H[h >> 2] = k.length;
                     H[h + 4 >> 2] = this.u;
                     H[h + 8 >> 2] = l;
                     h += 12;
-                    for (r of k) E.set(r, l >> 2), l += this.s;
+                    for (r of k) D.set(r, l >> 2), l += this.s;
                 }
                 d = h;
-                for (k = 0; r = g[k++]; ) H[h >> 2] = r.length, H[h + 4 >> 2] = l, h += 8, E.set(r, l >> 2), 
+                for (k = 0; r = g[k++]; ) H[h >> 2] = r.length, H[h + 4 >> 2] = l, h += 8, D.set(r, l >> 2), 
                 l += 4 * r.length;
                 g = h;
                 for (k of f) H[h >> 2] = k.length, H[h + 4 >> 2] = this.u, H[h + 8 >> 2] = l, h += 12, 
                 l += this.s * k.length;
-                if (p = this.v(p, D, x, g, O, d, this.A)) for (k of f) for (r of k) r.set(this.B[--G]);
+                if (p = this.v(p, E, x, g, O, d, this.A)) for (k of f) for (r of k) r.set(this.B[--G]);
                 F(V);
                 return !!p;
             }
@@ -95,7 +95,7 @@ function w() {
     J = new Uint8Array(a);
     K = new Int32Array(a);
     H = new Uint32Array(a);
-    E = new Float32Array(a);
+    D = new Float32Array(a);
 }
 
 n || (v = m.mem || new WebAssembly.Memory({
@@ -169,9 +169,9 @@ var L = [], M = a => {
     b = H[b + 8 >> 2];
     for (var p = 0; g--; ) d.push({
         name: p++,
-        defaultValue: E[b >> 2],
-        minValue: E[b + 4 >> 2],
-        maxValue: E[b + 8 >> 2],
+        defaultValue: D[b >> 2],
+        minValue: D[b + 4 >> 2],
+        maxValue: D[b + 8 >> 2],
         automationRate: (K[b + 12 >> 2] ? "k" : "a") + "-rate"
     }), b += 16;
     R[a].audioWorklet.D.port.postMessage({
@@ -240,8 +240,7 @@ function y() {
         m.stackAlloc = ha;
         m.stackRestore = P;
         m.wasmTable = A;
-        n ? (Y(t.J, t.F), "undefined" === typeof AudioWorkletGlobalScope && (removeEventListener("message", N), 
-        L = L.forEach(M), addEventListener("message", M))) : a.i();
+        n ? (Y(t.J, t.F), q || (removeEventListener("message", N), L = L.forEach(M), addEventListener("message", M))) : a.i();
         n || X();
     }));
 }

test/codesize/test_minimal_runtime_code_size_audio_worklet.json

@@ -1,10 +1,10 @@
 {
   "a.html": 519,
   "a.html.gz": 357,
-  "a.js": 4075,
-  "a.js.gz": 2135,
+  "a.js": 4024,
+  "a.js.gz": 2127,
   "a.wasm": 1308,
   "a.wasm.gz": 876,
-  "total": 5902,
-  "total_gz": 3368
+  "total": 5851,
+  "total_gz": 3360
 }