Skip to content

Commit d6d3b16

Browse files
authored
Mark CROSS_ORIGIN as requiring pthreads and dynamic execution (#25582)
This setting was recently added in #25581 and it only currently has en effect on pthread-based programs. It is also not compatible with `-sNO_DYNAMIC_EXECUTION` because it depends on starting worker based on JS string. These errors look like this: ``` $ emcc -sCROSS_ORIGIN -pthread -sDYNAMIC_EXECUTION=0 hello.c emcc: error: CROSS_ORIGIN is not compatible with DYNAMIC_EXECUTION=0 ```
1 parent afae201 commit d6d3b16

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tools/link.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -677,6 +677,8 @@ def report_incompatible_settings():
677677
('MODULARIZE', 'NODEJS_CATCH_REJECTION', None),
678678
('MODULARIZE', 'NODEJS_CATCH_EXIT', None),
679679
('LEGACY_VM_SUPPORT', 'MEMORY64', None),
680+
('CROSS_ORIGIN', 'NO_DYNAMIC_EXECUTION', None),
681+
('CROSS_ORIGIN', 'NO_PTHREADS', None),
680682
]
681683

682684
for a, b, reason in incompatible_settings:

0 commit comments

Comments
 (0)