Skip to content

Commit d8c2e41

Browse files
authored
Remove support for FireFox < 33 in getCallstack (#23615)
Our min supported FF version if 40.
1 parent 601277c commit d8c2e41

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/lib/libstack_trace.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,14 @@ var LibraryStackTrace = {
2929
// Process all lines:
3030
var lines = callstack.split('\n');
3131
callstack = '';
32-
// New FF30 with column info: extract components of form:
32+
// Extract components of form:
3333
// ' Object._main@http://server.com:4324:12'
34-
var newFirefoxRe = new RegExp('\\s*(.*?)@(.*?):([0-9]+):([0-9]+)');
35-
// Old FF without column info: extract components of form:
36-
// ' Object._main@http://server.com:4324'
37-
var firefoxRe = new RegExp('\\s*(.*?)@(.*):(.*)(:(.*))?');
34+
var firefoxRe = new RegExp('\\s*(.*?)@(.*?):([0-9]+):([0-9]+)');
3835
// Extract components of form:
3936
// ' at Object._main (http://server.com/file.html:4324:12)'
4037
var chromeRe = new RegExp('\\s*at (.*?) \\\((.*):(.*):(.*)\\\)');
4138

42-
for (var l in lines) {
43-
var line = lines[l];
44-
39+
for (var line of lines) {
4540
var symbolName = '';
4641
var file = '';
4742
var lineno = 0;
@@ -54,7 +49,7 @@ var LibraryStackTrace = {
5449
lineno = parts[3];
5550
column = parts[4];
5651
} else {
57-
parts = newFirefoxRe.exec(line) || firefoxRe.exec(line);
52+
parts = firefoxRe.exec(line);
5853
if (parts?.length >= 4) {
5954
symbolName = parts[1];
6055
file = parts[2];

0 commit comments

Comments
 (0)