fix pipeline

Author: lkwinta

tools/file_packager.py

@@ -814,7 +814,7 @@ def generate_js(data_target, data_files, metadata):
       if options.support_node:
         code += '''
             if (isNode) {
-              return errback();
+              errback();
             }'''
       code += '''
           if (typeof indexedDB == 'undefined') {
@@ -823,7 +823,7 @@ def generate_js(data_target, data_files, metadata):
           try {
             var openRequest = indexedDB.open(DB_NAME, DB_VERSION);
           } catch (e) {
-            return errback(e);
+            errback(e);
           }
           openRequest.onupgradeneeded = (event) => {
             var db = /** @type {IDBDatabase} */ (event.target.result);
@@ -924,7 +924,7 @@ def generate_js(data_target, data_files, metadata):
             var getRequest = packages.get(`package/${packageName}/${chunkId}`);
             getRequest.onsuccess = (event) => {
               if (!event.target.result) {
-                return errback(new Error(`CachedPackageNotFound for: ${packageName}`));
+                errback(new Error(`CachedPackageNotFound for: ${packageName}`));
               }
               // If there's only 1 chunk, there's nothing to concatenate it with so we can just return it now
               if (chunkCount == 1) {
@@ -963,7 +963,7 @@ def generate_js(data_target, data_files, metadata):
         if (isNode) {
           require('fs').readFile(packageName, (err, contents) => {
             if (err) {
-              return errback(err);
+              errback(err);
             } else {
               callback(contents.buffer);
             }
@@ -979,7 +979,7 @@ def generate_js(data_target, data_files, metadata):
           .catch((cause) => errback(new Error(`Network Error: ${packageName}`, {cause}))) // If fetch fails, rewrite the error to include the failing URL & the cause.
           .then((response) => {
             if (!response.ok) {
-              return errback(new Error(`${response.status}: ${response.url}`));
+              errback(new Error(`${response.status}: ${response.url}`));
             }
 
             if (!response.body && response.arrayBuffer) { // If we're using the polyfill, readers won't be available...
@@ -988,7 +988,7 @@ def generate_js(data_target, data_files, metadata):
 
             const reader = response.body.getReader();
             const iterate = () => reader.read().then(handleChunk).catch((cause) => {
-              return errback(new Error(`Unexpected error while handling : ${response.url} ${cause}`, {cause}));
+              errback(new Error(`Unexpected error while handling : ${response.url} ${cause}`, {cause}));
             });
 
             const chunks = [];
@@ -1117,7 +1117,7 @@ def generate_js(data_target, data_files, metadata):
         if (isNode) {
           require('fs').readFile(metadataUrl, 'utf8', (err, contents) => {
             if (err) {
-              return handleError(err);
+              throwPackageError(err);
             } else {
               loadPackage(JSON.parse(contents));
             }
@@ -1139,9 +1139,9 @@ def generate_js(data_target, data_files, metadata):
           return response.json();
         }
       })
-      .catch((cause) => {
-        return handleError(new Error(`Network Error: ${packageName}`, {cause})
-      })) // If fetch fails, rewrite the error to include the failing URL & the cause.
+      .catch((cause) => 
+        throwPackageError(new Error(`Network Error: ${packageName}`, {cause}))
+      ) // If fetch fails, rewrite the error to include the failing URL & the cause.
       .then(loadPackage);
   }