Simplify test_dynamic_link. NFC (#22246)

- Use @parameterize
- Simply test logic
- Rename test_dynamic_link* tests to test_dylink* for consistency.

Author: sbc100

test/test_browser.py

@@ -3361,52 +3361,32 @@ def test_webidl(self, args):
     self.btest('webidl/test.cpp', '1', args=['--post-js', 'glue.js', '-I.', '-DBROWSER'] + args)
 
   @no_wasm64('https://github.com/llvm/llvm-project/issues/98778')
-  def test_dynamic_link(self):
+  @parameterized({
+    '': ([],),
+    'proxy_to_worker': (['--proxy-to-worker'],),
+  })
+  def test_dylink(self, args):
     create_file('main.c', r'''
+      #include <assert.h>
       #include <stdio.h>
       #include <stdlib.h>
       #include <string.h>
-      #include <emscripten.h>
       char *side(const char *data);
       int main() {
-        char *temp = side("hello through side\n");
-        char *ret = (char*)malloc(strlen(temp)+1);
-        strcpy(ret, temp);
-        temp[1] = 'x';
-        EM_ASM({
-          Module.realPrint = out;
-          out = (x) => {
-            if (!Module.printed) Module.printed = x;
-            Module.realPrint(x);
-          };
-        });
+        char *ret = side("hello through side\n");
         puts(ret);
-        EM_ASM({ assert(Module.printed === 'hello through side', ['expected', Module.printed]); });
+        assert(strcmp(ret, "hello through side\n") == 0);
         return 0;
       }
     ''')
     create_file('side.c', r'''
-      #include <stdlib.h>
       #include <string.h>
-      char *side(const char *data);
       char *side(const char *data) {
-        char *ret = (char*)malloc(strlen(data)+1);
-        strcpy(ret, data);
-        return ret;
+        return strdup(data);
       }
     ''')
     self.emcc('side.c', ['-sSIDE_MODULE', '-O2', '-o', 'side.wasm'])
-    self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', '-O2', 'side.wasm'])
-
-    print('wasm in worker (we can read binary data synchronously there)')
-
-    self.emcc('side.c', ['-sSIDE_MODULE', '-O2', '-o', 'side.wasm'])
-    self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', '-O2', '--proxy-to-worker', 'side.wasm'])
-
-    print('wasm (will auto-preload since no sync binary reading)')
-
-    # same wasm side module works
-    self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', '-O2', '-sEXPORT_ALL', 'side.wasm'])
+    self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', '-O2', 'side.wasm'] + args)
 
   def test_dlopen_async(self):
     create_file('side.c', 'int foo = 42;\n')
@@ -3467,7 +3447,7 @@ def do_run(src, expected_output, emcc_args):
 
   @requires_graphics_hardware
   @no_wasm64('https://github.com/llvm/llvm-project/issues/98778')
-  def test_dynamic_link_glemu(self):
+  def test_dylink_glemu(self):
     create_file('main.c', r'''
       #include <stdio.h>
       #include <string.h>
@@ -3493,7 +3473,7 @@ def test_dynamic_link_glemu(self):
 
     self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', '-O2', '-sLEGACY_GL_EMULATION', '-lSDL', '-lGL', 'side.wasm'])
 
-  def test_dynamic_link_many(self):
+  def test_dylink_many(self):
     # test asynchronously loading two side modules during startup
     create_file('main.c', r'''
       #include <assert.h>
@@ -3515,7 +3495,7 @@ def test_dynamic_link_many(self):
     self.emcc('side2.c', ['-sSIDE_MODULE', '-o', 'side2.wasm'])
     self.btest_exit(self.in_dir('main.c'), args=['-sMAIN_MODULE=2', 'side1.wasm', 'side2.wasm'])
 
-  def test_dynamic_link_pthread_many(self):
+  def test_dylink_pthread_many(self):
     # Test asynchronously loading two side modules during startup
     # They should always load in the same order
     # Verify that function pointers in the browser's main thread