Update ruff to latest version. NFC (#25598)

Author: sbc100

emcc.py

@@ -315,7 +315,7 @@ def run(args):
     linker_args = separate_linker_flags(newargs)[1]
     linker_args = [f.value for f in linker_args]
     # Delay import of link.py to avoid processing this file when only compiling
-    from tools import link
+    from tools import link  # noqa: PLC0415
     link.run_post_link(options.input_files[0], options, linker_args)
     return 0
 

emrun.py

@@ -387,7 +387,7 @@ def kill_browser_process():
     # so clear that record out.
     processname_killed_atexit = ''
 
-  if len(processname_killed_atexit):
+  if processname_killed_atexit:
     if emrun_options.android:
       logv("Terminating Android app '" + processname_killed_atexit + "'.")
       subprocess.call([ADB, 'shell', 'am', 'force-stop', processname_killed_atexit])

pyproject.toml

@@ -43,6 +43,7 @@ lint.ignore = [
   "E741",
   "PERF203",
   "PERF401",
+  "PLC0415",
   "PLR1704",
   "PLR5501",
   "PLW0602",

requirements-dev.txt

@@ -7,7 +7,7 @@
 coverage[toml]==6.5
 mypy==1.14
 psutil==7.0.0
-ruff==0.11.7
+ruff==0.14.1
 types-requests==2.32.0.20241016
 unittest-xml-reporting==3.2.0
 deadcode==2.3.1

test/common.py

@@ -1439,11 +1439,11 @@ def tearDown(self):
 
         left_over_files = set(temp_files_after_run) - set(self.temp_files_before_run)
         left_over_files = [f for f in left_over_files if not any(f.startswith(p) for p in ignorable_file_prefixes)]
-        if len(left_over_files):
-          errlog('ERROR: After running test, there are ' + str(len(left_over_files)) + ' new temporary files/directories left behind:')
+        if left_over_files:
+          errlog(f'ERROR: After running test, there are {len(left_over_files)} new temporary files/directories left behind:')
           for f in left_over_files:
             errlog('leaked file: ', f)
-          self.fail('Test leaked ' + str(len(left_over_files)) + ' temporary files!')
+          self.fail(f'Test leaked {len(left_over_files)} temporary files!')
 
   def get_setting(self, key, default=None):
     return self.settings_mods.get(key, default)

test/runner.py

@@ -421,7 +421,7 @@ def run_tests(options, suites):
     os.makedirs('out', exist_ok=True)
     # output fd must remain open until after testRunner.run() below
     output = open('out/test-results.xml', 'wb')
-    import xmlrunner  # type: ignore
+    import xmlrunner  # type: ignore  # noqa: PLC0415
     testRunner = xmlrunner.XMLTestRunner(output=output, verbosity=2,
                                          failfast=options.failfast)
     print('Writing XML test output to ' + os.path.abspath(output.name))

test/test_other.py

@@ -9,6 +9,7 @@
 import importlib
 import itertools
 import json
+import locale
 import os
 import random
 import re
@@ -13164,7 +13165,6 @@ def test_response_file_encoding(self):
     open('a.rsp.cp437', 'w', encoding='cp437').write('äö.c') # Write a response file with Windows CP-437 encoding ...
     self.run_process([EMCC, '@a.rsp.cp437']) # ... and test that with the explicit suffix present, it is properly decoded
 
-    import locale
     preferred_encoding = locale.getpreferredencoding(do_setlocale=False)
     print('Python locale preferredencoding: ' + preferred_encoding)
     open('a.rsp', 'w', encoding=preferred_encoding).write('äö.c') # Write a response file using Python preferred encoding

test/test_sockets.py

@@ -89,7 +89,7 @@ def __enter__(self):
       self.processes.append(process)
 
     try:
-      import websockify  # type: ignore
+      import websockify  # type: ignore # noqa: PLC0415
     except ModuleNotFoundError:
       raise Exception('Unable to import module websockify. Run "python3 -m pip install websockify" or set environment variable EMTEST_SKIP_PYTHON_DEV_PACKAGES=1 to skip this test.') from None
 

tools/building.py

@@ -15,7 +15,16 @@
 from subprocess import PIPE
 from typing import Dict, Set
 
-from . import cache, config, diagnostics, response_file, shared, utils, webassembly
+from . import (
+  cache,
+  config,
+  diagnostics,
+  js_optimizer,
+  response_file,
+  shared,
+  utils,
+  webassembly,
+)
 from .feature_matrix import UNSUPPORTED
 from .settings import settings
 from .shared import (
@@ -354,8 +363,7 @@ def opt_level_to_str(opt_level, shrink_level=0):
     return f'-O{min(opt_level, 3)}'
 
 
-def js_optimizer(filename, passes):
-  from . import js_optimizer
+def run_js_optimizer(filename, passes):
   try:
     return js_optimizer.run_on_file(filename, passes)
   except subprocess.CalledProcessError as e:
@@ -975,7 +983,7 @@ def wasm2js(js_file, wasm_file, opt_level, use_closure_compiler, debug_info, sym
       wasm2js_js = wasm2js_js.replace('\n }', '\n}')
       temp = shared.get_temp_files().get('.js').name
       utils.write_file(temp, wasm2js_js)
-      temp = js_optimizer(temp, passes)
+      temp = run_js_optimizer(temp, passes)
       wasm2js_js = utils.read_file(temp)
   # Closure compiler: in mode 1, we just minify the shell. In mode 2, we
   # minify the wasm2js output as well, which is ok since it isn't

tools/file_packager.py

@@ -571,7 +571,7 @@ def was_seen(name):
 
   ret = generate_js(data_target, data_files, metadata)
 
-  if options.force or len(data_files):
+  if options.force or data_files:
     if options.jsoutput is None:
       print(ret)
     else: