Skip to content

Commit e6587e7

Browse files
authored
[test] Remove two v8 workarounds that are not longer needed. NFC (#25113)
The first instance the bug was fixed. In the second instance the test now passed just fine but I don't really understand why it previously didn't
1 parent 8d9c908 commit e6587e7

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

test/test_other.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,9 +1707,6 @@ def test_stdin(self, args):
17071707
self.emcc(test_file('module/test_stdin.c'), args=args, output_filename='out.js')
17081708

17091709
for engine in config.JS_ENGINES:
1710-
if engine == config.V8_ENGINE:
1711-
print('skipping v8 due to https://github.com/emscripten-core/emscripten/issues/25010')
1712-
continue
17131710
output = self.run_js('out.js', engine, input='abcdef\nghijkl\n')
17141711
self.assertContained('abcdef\nghijkl\neof', output)
17151712

@@ -5983,9 +5980,6 @@ def test_returncode(self, no_exit):
59835980
for async_compile in (0, 1):
59845981
self.run_process([EMCC, 'src.c', '-sENVIRONMENT=node,shell', '-DCODE=%d' % code, '-sEXIT_RUNTIME=%d' % (1 - no_exit), '-DCALL_EXIT=%d' % call_exit, '-sWASM_ASYNC_COMPILATION=%d' % async_compile])
59855982
for engine in config.JS_ENGINES:
5986-
# async compilation can't return a code in d8
5987-
if async_compile and engine == config.V8_ENGINE:
5988-
continue
59895983
print(code, call_exit, async_compile, engine)
59905984
proc = self.run_process(engine + ['a.out.js'], stderr=PIPE, check=False)
59915985
msg = 'but keepRuntimeAlive() is set (counter=0) due to an async operation, so halting execution but not exiting the runtime'

0 commit comments

Comments
 (0)